From: Paul van der Walt <paul@denknerd.org>
To: Cyrill Schenkel <cyrill.schenkel@gmail.com>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: Add xcompmgr
Date: Fri, 23 Oct 2015 11:46:10 +0200 [thread overview]
Message-ID: <87si51or31.fsf@denknerd.org> (raw)
In-Reply-To: <87si517rav.fsf@SIRIUSGUIX00.i-did-not-set--mail-host-address--so-tickle-me>
Hello Cyrill,
Small comment.
> From dc8d0477c0644e9d54ebba6af955c3d4e29270fc Mon Sep 17 00:00:00 2001
> From: Cyrill Schenkel <cyrill.schenkel@gmail.com>
> Date: Fri, 23 Oct 2015 13:25:11 +0200
> Subject: [PATCH] gnu: Add xcompmgr
>
> * gnu/packages/xorg.scm (xcompmgr): New variable.
> ---
> gnu/packages/xorg.scm | 41 +++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 41 insertions(+)
>
> diff --git a/gnu/packages/xorg.scm b/gnu/packages/xorg.scm
> index b39bbd4..d51cd30 100644
> --- a/gnu/packages/xorg.scm
> +++ b/gnu/packages/xorg.scm
> @@ -4,6 +4,7 @@
> [...]
> + (arguments
> + `(#:phases (modify-phases %standard-phases
> + (add-before 'configure 'autogen
> + (lambda _
> + (setenv "NOCONFIGURE" "t")
> + (zero? (system* "./autogen.sh")))))))
> + (native-inputs
> [...]
Mark Weaver recently told me that autogen phases should be after 'unpack
instead of before 'configure, since the MIPS platform (and perhaps
others) sometimes need to adjust the output of autogen.sh.
I'll leave the real review to others :).
Kind regards,
p.
next prev parent reply other threads:[~2015-10-23 9:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-23 11:33 [PATCH] gnu: Add xcompmgr Cyrill Schenkel
2015-10-23 9:46 ` Paul van der Walt [this message]
2015-10-23 10:04 ` Paul van der Walt
2015-10-23 14:45 ` Cyrill Schenkel
2015-10-23 13:13 ` Paul van der Walt
2015-10-26 22:30 ` Ludovic Courtès
2015-10-27 9:09 ` Andreas Enge
2015-10-27 12:26 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87si51or31.fsf@denknerd.org \
--to=paul@denknerd.org \
--cc=cyrill.schenkel@gmail.com \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.