From mboxrd@z Thu Jan  1 00:00:00 1970
From: iyzsong@member.fsf.org (=?utf-8?B?5a6L5paH5q2m?=)
Subject: Re: [PATCH 2/2] gnu: Add gedit.
Date: Sun, 08 Nov 2015 20:06:27 +0800
Message-ID: <87si4gvgos.fsf@member.fsf.org>
References: <1446959917-25693-1-git-send-email-david.hashe@dhashe.com>
	<1446959917-25693-2-git-send-email-david.hashe@dhashe.com>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56156)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <iyzsong@163.com>) id 1ZvOk4-0006Fd-60
	for guix-devel@gnu.org; Sun, 08 Nov 2015 07:06:41 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <iyzsong@163.com>) id 1ZvOk0-0004bl-U8
	for guix-devel@gnu.org; Sun, 08 Nov 2015 07:06:40 -0500
Received: from m50-133.163.com ([123.125.50.133]:40477)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <iyzsong@163.com>) id 1ZvOjz-0004bW-Sc
	for guix-devel@gnu.org; Sun, 08 Nov 2015 07:06:36 -0500
In-Reply-To: <1446959917-25693-2-git-send-email-david.hashe@dhashe.com> (David
	Hashe's message of "Sat, 7 Nov 2015 23:18:37 -0600")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: David Hashe <david.hashe@dhashe.com>
Cc: guix-devel@gnu.org

David Hashe <david.hashe@dhashe.com> writes:

> * gnu/packages/gnome.scm (gedit): New variable.
> ---
>  gnu/packages/gnome.scm | 56 ++++++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 56 insertions(+)
>
> diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
> index 9bd1c31..b6ca7c7 100644
> --- a/gnu/packages/gnome.scm
> +++ b/gnu/packages/gnome.scm
> @@ -3693,3 +3693,59 @@ such as gzip tarballs.")
>  GTK+ text widget GtkTextView. It improves GtkTextView by implementing syntax
>  highlighting and other features typical of a source code editor.")
>     (license license:lgpl2.1+)))
> +
> +(define-public gedit
> + (package
> +   (name "gedit")
> +   (version "3.16.4")
Same here, I prefer 3.18.x.
> +   (source (origin
> +            (method url-fetch)
> +            (uri (string-append "mirror://gnome/sources/" name "/"
> +                                (version-major+minor version) "/"
> +                                name "-" version ".tar.xz"))
> +            (sha256
> +             (base32
> +              "1h2czf2v0krqr3kar4fm2vspim30rwdb2yhab34sdn23j7m3f291"))))
> +   (build-system glib-or-gtk-build-system)
> +   (arguments
> +    `(#:configure-flags '("--disable-spell") ; requires enchant
> +      #:phases
> +      (modify-phases %standard-phases
> +        (add-after
> +         'install 'wrap-eog
> +         (lambda* (#:key outputs #:allow-other-keys)
> +           (let ((out               (assoc-ref outputs "out"))
> +                 (gi-typelib-path   (getenv "GI_TYPELIB_PATH")))
> +             (wrap-program (string-append out "/bin/gedit")
> +               `("GI_TYPELIB_PATH" ":" prefix (,gi-typelib-path))))
> +           #t)))))
> +   (propagated-inputs
> +    `(("dconf" ,dconf)))
> +   (native-inputs
> +    `(("intltool" ,intltool)
> +      ("itstool", itstool)
> +      ("gobject-introspection" ,gobject-introspection)
> +      ("pkg-config" ,pkg-config)))
> +   (inputs
> +    `(("glib" ,glib)
> +      ("gtk+" ,gtk+)
> +      ("gtksourceview" ,gtksourceview)
> +      ("libpeas" ,libpeas)
> +      ("libxml2" ,libxml2)
> +      ;; TODO: enchant needed for spell plugin
> +      ;;("enchant" ,enchant)
enchant is avaliable from enchant.scm, we can add it.
> +      ("iso-codes" ,iso-codes)
> +      ("python-pygobject" ,python-pygobject)
> +      ("python" ,python)
> +      ("gvfs" ,gvfs)
> +      ("gsettings-desktop-schemas" ,gsettings-desktop-schemas)
> +      ("libx11" ,libx11)
> +      ("vala" ,vala)
> +      ("adwaita-icon-theme" ,adwaita-icon-theme)
> +      ("libsoup" ,libsoup)
> +      ("gnome-desktop" ,gnome-desktop)))
> +   (home-page "https://wiki.gnome.org/Apps/Gedit")
> +   (synopsis "GNOME text editor")
> +   (description "While aiming at simplicity and ease of use, gedit is a
> +powerful general purpose text editor. ")
> +   (license license:gpl2+)))
Otherwise, look good to me, thanks!