Re: [PATCH] gnu: ladspa: Update urls.

[Alex Kost <alezost@gmail.com>]

Alex Vong (2015-11-12 17:34 +0300) wrote:

[...]
> diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm
> index a6899a0..9ed21bd 100644
> --- a/gnu/packages/audio.scm
> +++ b/gnu/packages/audio.scm
> @@ -758,7 +758,9 @@ plugin function as a JACK application.")
>      (source (origin
>               (method url-fetch)
>               (uri (string-append
> -                   "http://www.ladspa.org/download/ladspa_sdk_"
> +                   "http://slackware.org.uk/slacky/slackware-13.0/multimedia/ladspa/"
> +                   version
> +                   "/src/ladspa_sdk_"
>                     version
>                     ".tgz"))

Please keep lines within 78 columns.  Split that long string, for
example like this:

             (uri (string-append
                   "http://slackware.org.uk/slacky/slackware-13.0"
                   "/multimedia/ladspa/" version
                   "/src/ladspa_sdk_" version ".tgz"))


>               (sha256
> @@ -781,7 +783,8 @@ plugin function as a JACK application.")
>                (("^CC.*")            "CC = gcc\n")
>                (("^CPP.*")           "CPP = g++\n"))))
>          (alist-delete 'build %standard-phases))))
> -    (home-page "http://ladspa.org")
> +    (home-page "https://community.ardour.org/files/doxygen/ladspa_8h_source.html")  ; Since the home page is gone,
> +    ;; we provide a link to the self-documented header file.

This ^^^ is an unusual way to write a comment.  I think it's better to
do it like this:

    ;; Since the home page is gone, we provide a link to the
    ;; self-documented header file.
    (home-page
     "https://community.ardour.org/files/doxygen/ladspa_8h_source.html")

Also as the home-page line is too long, I split it into 2 lines.

-- 
Alex