From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: [PATCH 2/2] gnu: Add Asymptote. Date: Fri, 01 Jan 2016 19:10:07 +0100 Message-ID: <87si2hgohs.fsf@gnu.org> References: <1451097632-3235-1-git-send-email-bavier@member.fsf.org> <1451097632-3235-3-git-send-email-bavier@member.fsf.org> <87lh8bsyqr.fsf@gnu.org> <20151231143047.1f62f832@member.fsf.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:36801) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aF49X-0006i2-7u for guix-devel@gnu.org; Fri, 01 Jan 2016 13:10:16 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aF49S-0007N1-G1 for guix-devel@gnu.org; Fri, 01 Jan 2016 13:10:15 -0500 In-Reply-To: <20151231143047.1f62f832@member.fsf.org> (Eric Bavier's message of "Thu, 31 Dec 2015 14:30:47 -0600") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Eric Bavier Cc: guix-devel@gnu.org Eric Bavier skribis: > On Wed, 30 Dec 2015 17:11:08 +0100 > ludo@gnu.org (Ludovic Court=C3=A8s) wrote: > >> Eric Bavier skribis: >>=20 >> > * gnu/packages/plotutils.scm (asymptote): New variable. >> > * gnu/packages/patches/asymptote-gsl2.patch: New file. >> > * gnu-system.am (dist_patch_DATA): Add it.=20=20 >>=20 >> [...] >>=20 >> > + (native-inputs >> > + `(("gs" ,ghostscript) ;For tests >> > + ("texinfo" ,texinfo) ;For generating documentation >> > + ("texlive" ,texlive) ;For tests and documentation= =20=20 >>=20 >> Would it be enough to depend on texlive-bin? > > Both tests and documentation creation depend on various .fmt and .sty > files from the texlive package, so texlive-bin would not be enough it > seems. OK. >> Alternately, could documentation be made a separate package? > > Do you mean "package" rather than "output"? I was thinking of a separate package (as done for NumPy IIRC), but maybe that=E2=80=99s impractical. > I had tried doing a separate output originally. The issue is that the > 'asy' binary in "out" ends up with a reference to the "doc" output for > the 'help' command in its interactive mode. OK. Perhaps you could leave that as a comment to future readers who will want to do the same. :-) The same problem arises with TeX Live itself, where =E2=80=98texdoc=E2=80= =99 keeps a reference to the documentation directory, preventing the addition of a separate output. Similarly with Perl and =E2=80=98perldoc=E2=80=99. Annoy= ing! >> Otherwise LGTM, thanks! > > Attached is an updated patch suitable for master that adds a > libgc-for-c++ since it's a semi-private package. Is this alright, or > should it be two patches? That=E2=80=99s OK. > From 2faf8a6c093739c4b8980b337a6a0ed659e84ebf Mon Sep 17 00:00:00 2001 > From: Eric Bavier > Date: Sun, 20 Dec 2015 16:24:24 -0600 > Subject: [PATCH 2/2] gnu: Add Asymptote. > > * gnu/packages/bdw-gc.scm (libgc-for-c++): New variable. > * gnu/packages/plotutils.scm (asymptote): New variable. > * gnu/packages/patches/asymptote-gsl2.patch: New file. > * gnu-system.am (dist_patch_DATA): Add it. [...] > +;;; TODO: Remove this package once libgc is updated from core-updates. > +(define-public libgc-for-c++ > + (package (inherit libgc) Please change the =E2=80=98name=E2=80=99 field to, say, =E2=80=9Clibgc-cxx= =E2=80=9D, so that UIs don=E2=80=99t show two different =E2=80=9Clibgc=E2=80=9D packages. Otherwise LGTM, thanks! Ludo=E2=80=99.