Re: [PATCH 2/2] gnu: Add Asymptote.

[ludo@gnu.org (Ludovic Courtès)]

Eric Bavier <bavier@member.fsf.org> skribis:

> On Wed, 30 Dec 2015 17:11:08 +0100
> ludo@gnu.org (Ludovic Courtès) wrote:
>
>> Eric Bavier <bavier@member.fsf.org> skribis:
>> 
>> > * gnu/packages/plotutils.scm (asymptote): New variable.
>> > * gnu/packages/patches/asymptote-gsl2.patch: New file.
>> > * gnu-system.am (dist_patch_DATA): Add it.  
>> 
>> [...]
>> 
>> > +    (native-inputs
>> > +     `(("gs" ,ghostscript)              ;For tests
>> > +       ("texinfo" ,texinfo)             ;For generating documentation
>> > +       ("texlive" ,texlive)             ;For tests and documentation  
>> 
>> Would it be enough to depend on texlive-bin?
>
> Both tests and documentation creation depend on various .fmt and .sty
> files from the texlive package, so texlive-bin would not be enough it
> seems.

OK.

>> Alternately, could documentation be made a separate package?
>
> Do you mean "package" rather than "output"?

I was thinking of a separate package (as done for NumPy IIRC), but maybe
that’s impractical.

> I had tried doing a separate output originally. The issue is that the
> 'asy' binary in "out" ends up with a reference to the "doc" output for
> the 'help' command in its interactive mode.

OK.  Perhaps you could leave that as a comment to future readers who
will want to do the same.  :-)

The same problem arises with TeX Live itself, where ‘texdoc’ keeps a
reference to the documentation directory, preventing the addition of a
separate output.  Similarly with Perl and ‘perldoc’.  Annoying!

>> Otherwise LGTM, thanks!
>
> Attached is an updated patch suitable for master that adds a
> libgc-for-c++ since it's a semi-private package.  Is this alright, or
> should it be two patches?

That’s OK.

> From 2faf8a6c093739c4b8980b337a6a0ed659e84ebf Mon Sep 17 00:00:00 2001
> From: Eric Bavier <bavier@member.fsf.org>
> Date: Sun, 20 Dec 2015 16:24:24 -0600
> Subject: [PATCH 2/2] gnu: Add Asymptote.
>
> * gnu/packages/bdw-gc.scm (libgc-for-c++): New variable.
> * gnu/packages/plotutils.scm (asymptote): New variable.
> * gnu/packages/patches/asymptote-gsl2.patch: New file.
> * gnu-system.am (dist_patch_DATA): Add it.

[...]

> +;;; TODO: Remove this package once libgc is updated from core-updates.
> +(define-public libgc-for-c++
> +  (package (inherit libgc)

Please change the ‘name’ field to, say, “libgc-cxx”, so that UIs don’t
show two different “libgc” packages.

Otherwise LGTM, thanks!

Ludo’.