From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: [PATCH] gnu: Add pass. Date: Tue, 09 Feb 2016 22:36:30 +0100 Message-ID: <87si11pnvl.fsf@gnu.org> References: <87lh6u6dnj.fsf@tsyesika.se> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:54945) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aTFxd-00077W-3l for guix-devel@gnu.org; Tue, 09 Feb 2016 16:36:38 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aTFxZ-0006mG-Tm for guix-devel@gnu.org; Tue, 09 Feb 2016 16:36:37 -0500 In-Reply-To: <87lh6u6dnj.fsf@tsyesika.se> (Jessica Tallon's message of "Mon, 08 Feb 2016 23:27:44 +0100") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Jessica Tallon Cc: Guix-devel Hi! Jessica Tallon skribis: > From 86ab2ad8f47cb72780cf0140352a9a5c26af36f8 Mon Sep 17 00:00:00 2001 > From: Jessica Tallon > Date: Mon, 8 Feb 2016 22:12:50 +0100 > Subject: [PATCH] gnu: Add pass. > > * gnu/packages/password-utils.scm (pass): New variable. [...] > +(define-public pass > + (package > + (name "pass") I think we should call it =E2=80=9Cpassword-store=E2=80=9D since that=E2=80= =99s the upstream name. > + ;; The tests mysteriously hang, I've tired it outside of guix and > + ;; they run perfectly fine. Not sure why so for now I've disabled > + ;; them. > + #:tests? #f I added =E2=80=98set -x=E2=80=99 to src/password-store.sh and run =E2=80=98= make check=E2=80=99 within =E2=80=98guix environment --container=E2=80=99, which gave this: --8<---------------cut here---------------start------------->8--- # ./src/password-store.sh init 000432 + GPG_OPTS=3D("--quiet" "--yes" "--compress-algo=3Dnone" "--no-encrypt-to") + GPG=3Dgpg ++ tty + export GPG_TTY=3D/dev/console + GPG_TTY=3D/dev/console + which gpg2 + [[ -n '' ]] + [[ gpg =3D=3D \g\p\g\2 ]] + PREFIX=3D/homeless-shelter/.password-store + X_SELECTION=3Dclipboard + CLIP_TIME=3D45 + export GIT_DIR=3D/homeless-shelter/.password-store/.git + GIT_DIR=3D/homeless-shelter/.password-store/.git + export GIT_WORK_TREE=3D/homeless-shelter/.password-store + GIT_WORK_TREE=3D/homeless-shelter/.password-store + GETOPT=3Dgetopt + SHRED=3D'shred -f -z' ++ dirname ./src/password-store.sh ++ uname ++ cut -d _ -f 1 ++ tr '[:upper:]' '[:lower:]' + source ./src/platform/linux.sh + PROGRAM=3Dpassword-store.sh + COMMAND=3Dinit + case "$1" in + shift + cmd_init 000432 + local opts id_path=3D ++ getopt -o p: -l path: -n password-store.sh -- 000432 ./src/password-store.sh: line 263: getopt: command not found + opts=3D + local err=3D127 + eval set -- '' ++ set -- + true + case $1 in + true + case $1 in [=E2=80=A6 endless loop=E2=80=A6] --8<---------------cut here---------------end--------------->8--- So I think adding util-linux (which provides the =E2=80=98getopt=E2=80=99 c= ommand) as an input will solve the problem. > + (description "Pass is a password manager which uses gnupg to store, = retrieve > +generated passwords. The tool stores each password in its own file gpg > +encrypted allowing the program to be simple yet secure. Synchronization= is > +possible with inbuild git support which commits changes to your password= database > +to a git repository that can be managed through the pass command.") s/gnupg/GnuPG/; s/git/Git/; s/gpg/@command{gpg}/ :-) Could you send an updated patch? Thank you! Ludo=E2=80=99.