From: Alex Kost <alezost@gmail.com>
To: Kei Yamashita <kei@openmailbox.org>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] Add MilkyTracker to Guix
Date: Mon, 28 Mar 2016 13:46:06 +0300 [thread overview]
Message-ID: <87shzayj69.fsf@gmail.com> (raw)
In-Reply-To: <20160327230935.14e8ba5a@openmailbox.org> (Kei Yamashita's message of "Sun, 27 Mar 2016 23:09:35 -0400")
Kei Yamashita (2016-03-28 06:09 +0300) wrote:
> On Sun, 27 Mar 2016 10:23:37 +0300
> Efraim Flashner <efraim@flashner.co.il> wrote:
>> On Fri, Mar 25, 2016 at 07:54:40PM -0400, kei@openmailbox.org wrote:
[...]
>> > + (arguments
>> > + '(#:configure-flags `("--without-alsa" "--without-jack")))
>>
>> In addition to Nil's comments, I was wondering about the configure
>> flags. Wouldn't it make sense to have either alsa or jack as an input?
>
> Milkytracker works fine without it on my machine. I feel like it's a
> matter of allowing the user options or sticking to the minimal build.
In my understanding (I may be wrong) our policy is to provide
full-featured software, so the features shouldn't be disabled without a
reason. Sometimes we add minimal packages (e.g., "bash-minimal",
"cups-minimal") if they are needed, but this is not such a case.
So I think you should remove these --without-… flags. And thanks for
contributing!
--
Alex
next prev parent reply other threads:[~2016-03-28 10:46 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-25 23:54 [PATCH] Add MilkyTracker to Guix kei
2016-03-26 10:11 ` Nils Gillmann
2016-03-27 7:23 ` Efraim Flashner
2016-03-28 3:09 ` Kei Yamashita
2016-03-28 10:46 ` Alex Kost [this message]
2016-03-28 14:26 ` Ricardo Wurmus
2016-03-28 17:30 ` Kei Yamashita
2016-03-28 17:39 ` Kei Yamashita
2016-03-28 17:43 ` Kei Yamashita
2016-03-28 19:31 ` Kei Yamashita
2016-03-29 9:52 ` Alex Kost
2016-03-30 2:24 ` Kei Yamashita
2016-03-30 2:36 ` Leo Famulari
2016-03-30 20:52 ` Alex Kost
2016-03-27 14:17 ` Nils Gillmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87shzayj69.fsf@gmail.com \
--to=alezost@gmail.com \
--cc=guix-devel@gnu.org \
--cc=kei@openmailbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.