From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Nieuwenhuizen Subject: Re: [PATCH 07/10] gnu: ncurses: support mingw. Date: Mon, 02 May 2016 20:41:31 +0200 Message-ID: <87shy0wbdw.fsf@drakenvlieg.flower> References: <1461942751-23883-1-git-send-email-janneke@gnu.org> <1461942751-23883-7-git-send-email-janneke@gnu.org> <87r3dknant.fsf@igalia.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:50017) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1axInT-0006b8-8n for guix-devel@gnu.org; Mon, 02 May 2016 14:42:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1axInH-0008AH-FJ for guix-devel@gnu.org; Mon, 02 May 2016 14:42:13 -0400 In-Reply-To: <87r3dknant.fsf@igalia.com> (Andy Wingo's message of "Mon, 02 May 2016 10:09:42 +0200") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Andy Wingo Cc: guix-devel@gnu.org Andy Wingo writes: > On Fri 29 Apr 2016 17:12, Jan Nieuwenhuizen writes: > >> @@ -36,6 +39,7 @@ >> #:allow-other-keys) >> (let ((out (assoc-ref outputs "out")) >> (doc (assoc-ref outputs "doc"))) >> + (format #t "configure flags: ~s~%" configure-flags) >> (zero? (apply system* "./configure" >> (string-append "SHELL=3D" (which "sh")) >> (string-append "--build=3D" build) > > Please remove :) Hmm. Yes. I should maybe at least have put this in the commit message? It started out as a debug message...it confused me that the log file did not mention my extra configure flags until I found guix/build/gnu-build-system.scm (configure): (format #t "source directory: ~s (relative from build: ~s)~%" abs-srcdir srcdir) (if out-of-source? (begin (mkdir "../build") (chdir "../build"))) (format #t "build directory: ~s~%" (getcwd)) (format #t "configure flags: ~s~%" flags) and I thought that at least printing the configure flags in ncurses' custom configure stage would be nice. WDYT? > Otherwise LGTM. Otherwise I'd gladly remove it. Greetings, Jan --=20 Jan Nieuwenhuizen | GNU LilyPond http://lilypond.org Freelance IT http://JoyofSource.com | Avatar=C2=AE http://AvatarAcademy.nl= =20=20