From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ricardo Wurmus Subject: Re: [PATCH] build: emacs: Search elisp files in "share/emacs/site-lisp". Date: Thu, 23 Jun 2016 07:30:55 +0200 Message-ID: <87shw4jwts.fsf@elephly.net> References: <87d1ncatv8.fsf@gmail.com> <87mvme1gtw.fsf@mdc-berlin.de> <87poramg09.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:33457) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bFxEO-0000yT-4p for guix-devel@gnu.org; Thu, 23 Jun 2016 01:31:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bFxEM-00083o-5d for guix-devel@gnu.org; Thu, 23 Jun 2016 01:31:11 -0400 In-reply-to: <87poramg09.fsf@gnu.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Ludovic =?utf-8?Q?Court=C3=A8s?= Cc: guix-devel@gnu.org, Alex Kost Ludovic Courtès writes: > Ricardo Wurmus skribis: > >> Alex Kost writes: >> >>> Ricardo found a problem while working on some emacs package that >>> requires EMMS: the elisp file(s) of this package is(are) not compiled. >>> >>> This happens because currently emacs-build-system adds only >>> "share/emacs/site-lisp/guix.d/" to emacs load-path when it >>> compiles elisp files, but some emacs packages (for example, emms) put >>> their files in "share/emacs/site-lisp", so this directory should also be >>> added. The attached patch will do it. >> >> Thank you for the patch! This looks like the right thing to do. > > +1 > >> Should we also (in a later patch) add a way to override or append to the >> list of directories, e.g. via the “arguments“ field? > > FWIW I’m not convinced this is necessary, but we can always see later. You are probably right. I thought that packages like Lilypond install their Elisp files elsewhere, but it’s actually “share/emacs/site-lisp” as expected. ~~ Ricardo