From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH 2/2] services: Add 'dropbear-service'.
Date: Fri, 15 Jul 2016 18:00:56 +0200
Message-ID: <87shvazy9z.fsf@gnu.org>
References: <20160713161312.20282-1-david@craven.ch>
	<20160713161312.20282-3-david@craven.ch>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46002)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1bO5Y2-0003Yh-Ax
	for guix-devel@gnu.org; Fri, 15 Jul 2016 12:01:10 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1bO5Xw-000510-1W
	for guix-devel@gnu.org; Fri, 15 Jul 2016 12:01:05 -0400
In-Reply-To: <20160713161312.20282-3-david@craven.ch> (David Craven's message
	of "Wed, 13 Jul 2016 18:13:12 +0200")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: David Craven <david@craven.ch>
Cc: guix-devel@gnu.org

David Craven <david@craven.ch> skribis:

> * gnu/services/ssh.scm (dropbear-service, ...): New variables.
> * doc/guix.texi: New node.

Applied with these modifications:

  =E2=80=A2 I exposed and documented =E2=80=98dropbear-configuration=E2=80=
=99 (we should do the
    same with =E2=80=98lsh-configuration=E2=80=99 eventually);

  =E2=80=A2 I used the #:pid-file option of =E2=80=98make-forkexec-construc=
tor=E2=80=99;

  =E2=80=A2 Turned =E2=80=98dropbear-command=E2=80=99 into a gexp (instead =
of a list);

  =E2=80=A2 Fixed indentation of a few things;

  =E2=80=A2 Added a comment for =E2=80=9C-R=E2=80=9D.

  =E2=80=A2 Added a copyright line for you;

  =E2=80=A2 Added a full commit log.

Thanks!

Ludo=E2=80=99.