From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ricardo Wurmus <rekado@elephly.net>
Subject: Re: [PATCH] gnu: Add ircii.
Date: Fri, 05 Aug 2016 13:17:04 +0200
Message-ID: <87shujh3db.fsf@elephly.net>
References: <87fuqoe10m.fsf@we.make.ritual.n0.is>
	<20160802005413.GB15847@jasmine> <20160802075834.GB1957@solar>
	<878twf4dcu.fsf@we.make.ritual.n0.is> <87y44bhfvz.fsf@elephly.net>
	<874m6zwlss.fsf@we.make.ritual.n0.is>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46340)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rekado@elephly.net>) id 1bVd7x-0000XU-6J
	for guix-devel@gnu.org; Fri, 05 Aug 2016 07:17:22 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rekado@elephly.net>) id 1bVd7s-0004z2-Tq
	for guix-devel@gnu.org; Fri, 05 Aug 2016 07:17:20 -0400
Received: from sender163-mail.zoho.com ([74.201.84.163]:24585)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rekado@elephly.net>) id 1bVd7s-0004yj-LA
	for guix-devel@gnu.org; Fri, 05 Aug 2016 07:17:16 -0400
In-reply-to: <874m6zwlss.fsf@we.make.ritual.n0.is>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: ng0 <ng0@we.make.ritual.n0.is>
Cc: guix-devel@gnu.org


ng0 <ng0@we.make.ritual.n0.is> writes:

> Ricardo Wurmus <rekado@elephly.net> writes:
>
>> ng0 <ng0@we.make.ritual.n0.is> writes:
>>
>>> Thanks, in the new revision of the patch both issues you two found are
>>> fixed.
>>
>>> +         (replace 'configure
>>> +           (lambda* (#:key inputs outputs #:allow-other-keys)
>>> +             (let ((out (assoc-ref outputs "out"))
>>> +                   (ncurses (assoc-ref inputs "ncurses"))
>>> +                   (openssl (assoc-ref inputs "openssl")))
>>> +               (setenv "CONFIG_SHELL" (which "bash"))
>>> +               (zero?
>>> +                (system* "./configure"
>>> +                         ;; TODO: find a socks4+5 lib with small size
>>> +                         ;; (string-append "--with-socks5=" ghc-socks)
>>> +                         (string-append "--prefix=" out)
>>> +                         (string-append "--enable-ipv6")
>>> +                         (string-append "--with-openssl=" openssl)
>>> +                         (string-append "--with-emacs-meta-keys")))))))))
>>
>> Why is this needed?  Did you try using #:configure-flags instead of
>> replacing the configure phase?  You can refer to inputs with
>> “%build-inputs” there.
>>
>> ~~ Ricardo
>>
>
> I can try to put it into configure flags, I wrote it like this because
> the README suggested it. I'll send a new patch when I'm done with the
> gnurl update.

Which README file suggested overriding the configure phase?

~~ Ricardo