Re: [PATCH] gnu: Add ircii.

[Ricardo Wurmus <rekado@elephly.net>]

ng0 <ng0@we.make.ritual.n0.is> writes:

> Ricardo Wurmus <rekado@elephly.net> writes:
>
>> ng0 <ng0@we.make.ritual.n0.is> writes:
>>
>>> Thanks, in the new revision of the patch both issues you two found are
>>> fixed.
>>
>>> +         (replace 'configure
>>> +           (lambda* (#:key inputs outputs #:allow-other-keys)
>>> +             (let ((out (assoc-ref outputs "out"))
>>> +                   (ncurses (assoc-ref inputs "ncurses"))
>>> +                   (openssl (assoc-ref inputs "openssl")))
>>> +               (setenv "CONFIG_SHELL" (which "bash"))
>>> +               (zero?
>>> +                (system* "./configure"
>>> +                         ;; TODO: find a socks4+5 lib with small size
>>> +                         ;; (string-append "--with-socks5=" ghc-socks)
>>> +                         (string-append "--prefix=" out)
>>> +                         (string-append "--enable-ipv6")
>>> +                         (string-append "--with-openssl=" openssl)
>>> +                         (string-append "--with-emacs-meta-keys")))))))))
>>
>> Why is this needed?  Did you try using #:configure-flags instead of
>> replacing the configure phase?  You can refer to inputs with
>> “%build-inputs” there.
>>
>> ~~ Ricardo
>>
>
> I can try to put it into configure flags, I wrote it like this because
> the README suggested it. I'll send a new patch when I'm done with the
> gnurl update.

Which README file suggested overriding the configure phase?

~~ Ricardo