From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ricardo Wurmus <rekado@elephly.net>
Subject: Re: [PATCH 1/5] gnu: Add libvirt.
Date: Wed, 10 Aug 2016 16:13:20 +0200
Message-ID: <87shucd85b.fsf@elephly.net>
References: <20160803154603.6939-1-rekado@elephly.net>
	<20160803154603.6939-2-rekado@elephly.net>
	<20160807022624.GA11896@jasmine>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53113)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rekado@elephly.net>) id 1bXUG9-0003LS-V2
	for guix-devel@gnu.org; Wed, 10 Aug 2016 10:13:30 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rekado@elephly.net>) id 1bXUG5-0002l5-PK
	for guix-devel@gnu.org; Wed, 10 Aug 2016 10:13:29 -0400
Received: from sender163-mail.zoho.com ([74.201.84.163]:24472)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rekado@elephly.net>) id 1bXUG5-0002l0-Gq
	for guix-devel@gnu.org; Wed, 10 Aug 2016 10:13:25 -0400
In-reply-to: <20160807022624.GA11896@jasmine>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Leo Famulari <leo@famulari.name>
Cc: guix-devel@gnu.org


Leo Famulari <leo@famulari.name> writes:

> On Wed, Aug 03, 2016 at 05:45:59PM +0200, Ricardo Wurmus wrote:
>> +         (add-after 'unpack 'fix-tests
>> +           (lambda _
>> +             (substitute* '("tests/commandtest.c"
>> +                            "gnulib/tests/test-posix_spawn1.c"
>> +                            "gnulib/tests/test-posix_spawn2.c")
>> +               (("/bin/sh") (which "bash")))
>> +             #t))
>
> According to the man page, Bash changes its behavior to be more POSIX-y
> when called as sh.  So, how about replacing these shebangs with (which
> "sh"), since their names suggest they are testing some POSIX behavior
> (at least the latter two tests).

Good point.  I’ll change this.

~~ Ricardo