From: ng0 <ng0@we.make.ritual.n0.is>
To: Alex Kost <alezost@gmail.com>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: Add toxic (Need help with ncurses+libnotify not being found).
Date: Sun, 21 Aug 2016 16:39:17 +0000 [thread overview]
Message-ID: <87shtyvzyi.fsf@we.make.ritual.n0.is> (raw)
In-Reply-To: <87pop2qvir.fsf@we.make.ritual.n0.is>
ng0 <ng0@we.make.ritual.n0.is> writes:
> Hi,
>
> thanks for the CPATH info, I will try that.
>
> Alex Kost <alezost@gmail.com> writes:
>
>> ng0 (2016-08-21 05:25 +0300) wrote:
>>
>>> There are serious cosmetic improvements I need to to make on these
>>> patches, I am aware of this, but what I am asking help for is:
>>>
>>> I've tried for hours many ways to make toxic find "libnotify" and
>>> "ncursesw" ... It does not
>>> happen... setenv. substitute. ldflags. user_ldflags. cflags. user_cflags. nothing..
>>>
>>> Can someone shed some light on this?
>>
>> As I see 'toxic' has a hand-written Makefile, so it probably doesn't use
>> pkg-config properly to find "libnotify". Did you try to add
>> "<libnotify-store-dir>/include/libnotify" to CPATH (as it is
>> done in 'webkitgtk' package, for example)?
>
> I think so, but I will try again, thanks for the package example.
>
>> [...]
>>> +(define-public libtoxcore
>>> + (let ((revision "1")
>>> + (commit "755f084e8720b349026c85afbad58954cb7ff1d4"))
>>> + (package
>>> + (name "libtoxcore")
>>> + (version (string-append "0.0.0" "-"
>>> + revision (string-take commit 8)))
>>> + (source (origin
>>> + (method git-fetch)
>>> + (uri (git-reference
>>> + (url "https://github.com/irungentoo/toxcore.git")
>>> + (commit commit)))
>>> + (file-name (string-append name "-" version))
>>
>> I prefer: (file-name (string-append name "-" version "-checkout"))
>> I think it is more clean.
>
> ^ see "I am aware of the fact that it needs cosmetic changes" or: wip is
> very wip at my side usually, I would've changed this before an official
> patch send.
>
>>> + (sha256
>>> + (base32
>>> + "0ap1gvlyihnfivv235dbrgsxsiiz70bhlmlr5gn1027w3h5kqz8w"))))
>>> + (build-system gnu-build-system)
>>> + (native-inputs
>>> + `(("autoconf" ,autoconf)
>>> + ("automake" ,automake)
>>> + ("libtool" ,libtool)
>>> + ;; TODO: Add when test suite is capable of passing.
>>> + ;; ("check" ,check)
>>> + ("pkg-config" ,pkg-config)))
>>> + (inputs
>>> + `(("libsodium" ,libsodium)
>>> + ("opus" ,opus)
>>> + ("libvpx" ,libvpx)))
>>> + (arguments
>>> + `(#:phases
>>> + (modify-phases %standard-phases
>>> + (add-before 'configure 'autoconf
>>
>> It should be added after 'unpack' phase, because... I forgot the reason :-)
>> but it relates to other phases between 'unpack' and 'configure' on "arm"
>> or "mips" systems.
>
> This package is a version bumped + changed alist to add-after/before
> package based on the pacakage davexunit has. I will adjust later.
>
>> [...]
>>> +(define-public toxic
>>> + (package
>>> + (name "toxic")
>>> + (version "0.7.0")
>>> + (source (origin
>>> + (method url-fetch)
>>> + (uri (string-append "https://github.com/JFreegman/"
>>> + name "/archive/v" version ".tar.gz"))
>>> + (file-name (string-append name "-" version))
>>
>> Don't forget to change it to:
>>
>> (file-name (string-append name "-" version ".tar.gz"))
I don't want to fix this. This is upstreams (toxic) problem, so I wait
on the result of my bugtickets.
The utox OrangeGoblin packaged works, I version bumped it.. I will
create an updated patch of libtoxcore, so that OrangeGoblin can send in
utox based on that.
--
ng0
For non-prism friendly talk find me on http://www.psyced.org
next prev parent reply other threads:[~2016-08-21 16:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-21 2:25 [PATCH] gnu: Add toxic (Need help with ncurses+libnotify not being found) ng0
2016-08-21 7:29 ` Alex Kost
2016-08-21 10:14 ` ng0
2016-08-21 16:39 ` ng0 [this message]
2016-08-21 17:31 ` [PATCH] gnu: Add libtoxcore ng0
2016-08-22 10:22 ` ng0
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87shtyvzyi.fsf@we.make.ritual.n0.is \
--to=ng0@we.make.ritual.n0.is \
--cc=alezost@gmail.com \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.