From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marius Bakke <mbakke@fastmail.com>
Subject: Re: [PATCH] gnu: Add mash.
Date: Thu, 01 Sep 2016 11:00:39 +0100
Message-ID: <87shtkq6rc.fsf@ike.i-did-not-set--mail-host-address--so-tickle-me>
References: <87h9a2yweu.fsf@ike.i-did-not-set--mail-host-address--so-tickle-me>
	<20160831194426.GC22495@jasmine> <87zinsae3u.fsf@elephly.net>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38109)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mbakke@fastmail.com>) id 1bfOnj-0007o8-8Q
	for guix-devel@gnu.org; Thu, 01 Sep 2016 06:00:55 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mbakke@fastmail.com>) id 1bfOnc-0008DD-Jm
	for guix-devel@gnu.org; Thu, 01 Sep 2016 06:00:50 -0400
Received: from out4-smtp.messagingengine.com ([66.111.4.28]:39868)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mbakke@fastmail.com>) id 1bfOnc-0008CX-84
	for guix-devel@gnu.org; Thu, 01 Sep 2016 06:00:44 -0400
In-Reply-To: <87zinsae3u.fsf@elephly.net>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Ricardo Wurmus <rekado@elephly.net>, Leo Famulari <leo@famulari.name>
Cc: guix-devel@gnu.org


Leo Famulari <leo@famulari.name> writes:

>> +         (add-after 'unpack 'fix-includes
>> +           (lambda _
>> +             (substitute* '("src/mash/Sketch.cpp" "src/mash/CommandFind.cpp")
>> +               (("^#include \"kseq\\.h\"")
>> +                "#include \"htslib/kseq.h\""))
>> +             #t))
>> +         (add-before 'configure 'autoconf
>> +           (lambda _ (zero? (system* "autoconf")))))))
>> +    (native-inputs
>> +     `(("autoconf" ,autoconf)
>> +       ("capnproto" ,capnproto)
>> +       ("htslib" ,htslib)))
>
> Does it only need to use capnproto and htslib while building? Okay if
> so.

I had these in inputs initially and was surprised to see no references.
Both seems to be compiled into the final program[0]: when running "mash
info" on an invalid file (the provided data/refseq.msh), a generic
capnproto exception is thrown (src/capnp/serialize.c++:159).

That raises another question: should the htslib and capnproto licenses
be listed too, since they are part of the binary output?

I'm not a bioinformatician (just a mere sysadmin for such), but have
been going through the tutorial and things appear to work fine.

0: https://github.com/marbl/Mash/blob/master/Makefile.in#L38