From: ludo@gnu.org (Ludovic Courtès)
To: Ricardo Wurmus <rekado@elephly.net>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 2/3] gnu: Add newlib-arm-none-eabi.
Date: Wed, 21 Sep 2016 17:38:36 +0900 [thread overview]
Message-ID: <87shstlkab.fsf@gnu.org> (raw)
In-Reply-To: <20160918063513.11027-3-rekado@elephly.net> (Ricardo Wurmus's message of "Sun, 18 Sep 2016 08:35:12 +0200")
Ricardo Wurmus <rekado@elephly.net> skribis:
> * gnu/packages/embedded.scm (newlib-arm-none-eabi): New variable.
[...]
> + #:configure-flags '("--target=arm-none-eabi"
> + "--enable-newlib-io-long-long"
> + "--enable-newlib-register-fini"
> + "--disable-newlib-supplied-syscalls"
> + "--disable-nls")
Maybe a short comment to explain. :-)
> + #:phases
> + (modify-phases %standard-phases
> + (add-after 'unpack 'fix-shell-shebangs
> + (lambda _
> + (setenv "SHELL" (which "sh"))
> + (setenv "CONFIG_SHELL" (which "sh"))
> + (substitute* '("libgloss/arm/configure"
> + "libgloss/arm/cpu-init/Makefile.in"
> + "libgloss/arm/Makefile.in"
> + "libgloss/libnosys/Makefile.in"
> + "libgloss/Makefile.in")
> + (("/bin/sh") (which "sh")))
Are they not taken care of by the ‘patch-shebangs’ phase?
Otherwise LGTM, thanks!
Ludo’.
next prev parent reply other threads:[~2016-09-21 14:50 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-18 6:35 [PATCH 0/3] Add GCC cross compiler for arm-none-eabi Ricardo Wurmus
2016-09-18 6:35 ` [PATCH 1/3] gnu: Add arm-none-eabi cross compiler Ricardo Wurmus
2016-09-21 8:34 ` Ludovic Courtès
2016-09-18 6:35 ` [PATCH 2/3] gnu: Add newlib-arm-none-eabi Ricardo Wurmus
2016-09-21 8:38 ` Ludovic Courtès [this message]
2016-09-18 6:35 ` [PATCH 3/3] gnu: Add newlib-nano-arm-none-eabi Ricardo Wurmus
2016-09-21 8:40 ` Ludovic Courtès
2016-10-02 18:47 ` Ricardo Wurmus
2016-09-19 20:23 ` [PATCH v2 0/4] Add GCC cross compiler for arm-none-eabi Theodoros Foradis
2016-09-19 20:23 ` [PATCH v2 1/4] gnu: Add arm-none-eabi cross compiler Theodoros Foradis
2016-09-19 20:23 ` [PATCH v2 2/4] gnu: Add arm-none-eabi-gcc-6 and patches Theodoros Foradis
2016-10-10 20:22 ` Ricardo Wurmus
2016-09-19 20:23 ` [PATCH v2 3/4] gnu: Add newlib-arm-none-eabi Theodoros Foradis
2016-09-19 20:23 ` [PATCH v2 4/4] gnu: Add arm-none-eabi-toolchain Theodoros Foradis
2016-09-27 9:03 ` [PATCH v2 0/4] Add GCC cross compiler for arm-none-eabi Ludovic Courtès
2016-09-29 9:24 ` Ricardo Wurmus
2016-09-29 17:39 ` Theodoros Foradis
2016-10-10 18:09 ` Theodoros Foradis
2016-10-10 18:23 ` Ricardo Wurmus
2016-10-11 15:50 ` theodoros.for
2016-10-16 10:01 ` Ricardo Wurmus
2016-10-23 17:01 ` Theodoros Foradis
2016-11-26 8:55 ` Ricardo Wurmus
2016-09-20 10:50 ` [PATCH v2 0/1] " Theodoros Foradis
2016-09-20 10:50 ` [PATCH v2 1/4] gnu: Add arm-none-eabi cross compiler Theodoros Foradis
2016-09-20 10:50 ` [PATCH v2 2/4] gnu: Add arm-none-eabi-gcc-6 and patches Theodoros Foradis
2016-09-20 10:50 ` [PATCH v2 3/4] gnu: Add newlib-arm-none-eabi Theodoros Foradis
2016-09-20 10:50 ` [PATCH v2 4/4] gnu: Add arm-none-eabi-toolchain Theodoros Foradis
2016-09-21 8:30 ` [PATCH 0/3] Add GCC cross compiler for arm-none-eabi Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87shstlkab.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=guix-devel@gnu.org \
--cc=rekado@elephly.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.