all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: ludo@gnu.org (Ludovic Courtès)
To: David Craven <david@craven.ch>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 1/7] build-system: Add cargo build system.
Date: Tue, 04 Oct 2016 11:03:24 +0200	[thread overview]
Message-ID: <87shsccwpv.fsf@gnu.org> (raw)
In-Reply-To: <20160928151538.11679-1-david@craven.ch> (David Craven's message of "Wed, 28 Sep 2016 17:15:32 +0200")

David Craven <david@craven.ch> skribis:

> * guix/build-system/cargo.scm (default-cargo, default-rustc,
>   %cargo-build-system-modules, cargo-build, lower, cargo-build-system):
>   New variables.
> * guix/build/cargo-build-system.scm (configure, build, check, install,
>   %standard-phases, cargo-build): New variables.

[...]

> +(define* (install #:key inputs outputs #:allow-other-keys)
> +  "Install a given Cargo package."
> +  (let* ((out (assoc-ref outputs "out"))
> +         (src (assoc-ref inputs "source"))
> +         (bin (string-append out "/bin"))
> +         (rsrc (string-append out "/rustsrc")))
> +    (mkdir-p rsrc)
> +    ;; Rust doesn't have a stable ABI yet. Because of this
> +    ;; Cargo doesn't have a search path for binaries yet.
> +    ;; Until this changes we are working around this by
> +    ;; distributing crates as source and replacing
> +    ;; references in Cargo.toml with store paths.
> +    (copy-recursively "src" (string-append rsrc "/src"))

OK.  In
<https://lists.gnu.org/archive/html/guix-devel/2016-09/msg01991.html>, I
suggested using ‘share/rust-source’ or similar to store the source.
Would it be possible?

Last thing: Could you add a couple of lines in guix.texi under “Build
Systems”?

OK with these changes.

Thanks!

Ludo’.

  parent reply	other threads:[~2016-10-04  9:03 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-28 15:15 [PATCH 1/7] build-system: Add cargo build system David Craven
2016-09-28 15:15 ` [PATCH 2/7] import: Add importer for rust crates David Craven
2016-10-04  9:14   ` Ludovic Courtès
2016-09-28 15:15 ` [PATCH 3/7] import: crate: Add crate updater David Craven
2016-10-04  9:05   ` Ludovic Courtès
2016-09-28 15:15 ` [PATCH 4/7] upstream: Use a the first url from urls when find2 returns #f David Craven
2016-09-28 15:19   ` David Craven
2016-10-04  9:07     ` Ludovic Courtès
2016-09-28 15:15 ` [PATCH 5/7] gnu: Add rustc-bootstrap David Craven
2016-09-28 15:20   ` David Craven
2016-09-29 12:35     ` David Craven
2016-10-04  8:57   ` Ludovic Courtès
2016-10-04  9:11     ` ng0
2016-10-04 13:09       ` Ludovic Courtès
2016-10-04 13:55         ` ng0
2016-10-04 13:59           ` David Craven
2016-10-04 14:11             ` ng0
2016-10-04  8:59   ` Ludovic Courtès
2016-09-28 15:15 ` [PATCH 6/7] gnu: Add cargo-bootstrap David Craven
2016-10-04  9:11   ` Ludovic Courtès
2016-09-28 15:15 ` [PATCH 7/7] gnu: Add rust-libc David Craven
2016-09-30  7:21 ` [PATCH 1/7] build-system: Add cargo build system Ricardo Wurmus
2016-09-30 10:49   ` David Craven
2016-10-04  9:03 ` Ludovic Courtès [this message]
2016-12-09 12:17   ` ng0
2016-12-09 14:17     ` Ludovic Courtès
2016-12-11 19:47       ` David Craven
2016-12-13 17:15         ` Ludovic Courtès
2016-12-13 18:07           ` David Craven
2016-12-13 22:11             ` Ludovic Courtès
2016-12-14 11:48               ` David Craven
2016-12-15 15:45                 ` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87shsccwpv.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=david@craven.ch \
    --cc=guix-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.