From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ricardo Wurmus <rekado@elephly.net>
Subject: Re: [PATCH 02/68] gnu: extra-cmake-modules: Update to 5.27.0.
Date: Sat, 29 Oct 2016 23:27:45 +0200
Message-ID: <87shrealri.fsf@elephly.net>
References: <20161029180519.6061-1-david@craven.ch>
	<20161029180519.6061-2-david@craven.ch>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36037)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rekado@elephly.net>) id 1c0bAY-0006zk-Pe
	for guix-devel@gnu.org; Sat, 29 Oct 2016 17:28:03 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rekado@elephly.net>) id 1c0bAT-0001pr-Ty
	for guix-devel@gnu.org; Sat, 29 Oct 2016 17:28:02 -0400
Received: from sender163-mail.zoho.com ([74.201.84.163]:21458)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <rekado@elephly.net>) id 1c0bAT-0001p4-Lw
	for guix-devel@gnu.org; Sat, 29 Oct 2016 17:27:57 -0400
In-reply-to: <20161029180519.6061-2-david@craven.ch>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: David Craven <david@craven.ch>
Cc: guix-devel@gnu.org


David Craven <david@craven.ch> writes:

> * gnu/packages/kde-frameworks.scm (extra-cmake-modules): Update to
>   5.27.0.
> ---
>  gnu/packages/kde-frameworks.scm | 20 ++++++++++----------
>  1 file changed, 10 insertions(+), 10 deletions(-)
>
> diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
> index 011f9e0..04cb6e8 100644
> --- a/gnu/packages/kde-frameworks.scm
> +++ b/gnu/packages/kde-frameworks.scm
> @@ -54,16 +54,16 @@
>  (define-public extra-cmake-modules
>    (package
>      (name "extra-cmake-modules")
> -    (version "5.24.0")
> -    (source
> -      (origin
> -        (method url-fetch)
> -        (uri (string-append "mirror://kde/stable/frameworks/"
> -                            (version-major+minor version) "/"
> -                            name "-" version ".tar.xz"))
> -        (sha256
> -         (base32
> -          "01m12ml529pwr2sal951r5z6yb1rwbpid1y4k14nlk3xqgmdakwa"))))
> +    (version "5.27.0")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append
> +                    "mirror://kde/stable/frameworks/"
> +                    (version-major+minor version) "/"
> +                    name "-" version ".tar.xz"))
> +              (sha256
> +               (base32
> +                "0n7vw2a4kxdgpsc1wn9f1d0y01p6qfk8ac360rq329bvdpigxmnj"))))
>      (build-system cmake-build-system)
>      (native-inputs
>       `(("qtbase" ,qtbase))) ; For tests (needs qmake)

I liked the previous indentation better, but feel free to ignore me :)
Looks good to me!

~~ Ricardo