From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marius Bakke Subject: Re: [PATCH] gnu: Add libtermkey Date: Tue, 06 Dec 2016 14:40:17 +0100 Message-ID: <87shq1mb0e.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> References: <6fd1116f162a782056c666b0ff705180@openmailbox.org> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:36677) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cEFys-0007vx-HA for guix-devel@gnu.org; Tue, 06 Dec 2016 08:40:27 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cEFyp-0003yP-BL for guix-devel@gnu.org; Tue, 06 Dec 2016 08:40:26 -0500 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:42396) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cEFyp-0003xe-4L for guix-devel@gnu.org; Tue, 06 Dec 2016 08:40:23 -0500 In-Reply-To: <6fd1116f162a782056c666b0ff705180@openmailbox.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: =?utf-8?Q?Jos=C3=A9?= Miguel =?utf-8?Q?S=C3=A1nchez_Garc=C3=ADa?= , guix-devel@gnu.org --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Jos=C3=A9 Miguel S=C3=A1nchez Garc=C3=ADa writes: > Add libtermkey (I hope it's finally correct!) Hi Jos=C3=A9, Thanks for your contribution! The patch looks mostly good, see comments inline. > > --=20 > Jos=C3=A9 Miguel S=C3=A1nchez Garc=C3=ADa > From 8ad5713a25aeb40b9021b30beba7b11d3cf432df Mon Sep 17 00:00:00 2001 > From: =3D?UTF-8?q?Jos=3DC3=3DA9=3D20Miguel=3D20S=3DC3=3DA1nchez=3D20Garc= =3DC3=3DADa?=3D > > Date: Mon, 5 Dec 2016 15:12:56 +0100 > Subject: [PATCH] gnu: Add libtermkey. > > --- > gnu/packages/libtermkey.scm | 54 +++++++++++++++++++++++++++++++++++++++= ++++++ > 1 file changed, 54 insertions(+) > create mode 100644 gnu/packages/libtermkey.scm I think this should go in 'terminals.scm' instead of a new file. We try to categorize related programs together to keep the file count low. > diff --git a/gnu/packages/libtermkey.scm b/gnu/packages/libtermkey.scm > new file mode 100644 > index 0000000..e3280ca > --- /dev/null > +++ b/gnu/packages/libtermkey.scm > @@ -0,0 +1,54 @@ > +;;; GNU Guix --- Functional package management for GNU > +;;; Copyright =C2=A9 2016 Jos=C3=A9 Miguel S=C3=A1nchez Garc=C3=ADa > +;;; > +;;; This file is part of GNU Guix. > +;;; > +;;; GNU Guix is free software; you can redistribute it and/or modify it > +;;; under the terms of the GNU General Public License as published by > +;;; the Free Software Foundation; either version 3 of the License, or (at > +;;; your option) any later version. > +;;; > +;;; GNU Guix is distributed in the hope that it will be useful, but > +;;; WITHOUT ANY WARRANTY; without even the implied warranty of > +;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > +;;; GNU General Public License for more details. > +;;; > +;;; You should have received a copy of the GNU General Public License > +;;; along with GNU Guix. If not, see . > + > +(define-module (gnu packages libtermkey) > + #:use-module (guix packages) > + #:use-module (guix download) > + #:use-module (guix build-system gnu) > + #:use-module (guix licenses) > + #:use-module (gnu packages autotools) > + #:use-module (gnu packages ncurses) > + #:use-module (gnu packages pkg-config)) > + > +(define-public libtermkey > + (package > + (name "libtermkey") > + (version "0.18") > + (source (origin > + (method url-fetch) > + (uri (string-append "http://www.leonerd.org.uk/code/" > + name "/" name "-" version ".tar.gz")) > + (sha256 > + (base32 "09ir16kaarv55mnc4jn2sqnjjhzpb1aha51wpd9ayif887g= 4d5r3")))) > + (build-system gnu-build-system) > + (arguments '( Please move the "'(" to the next line so that the indentation matches the start of the expression. Or move #:make-flags one line up and re-indent the rest of the block, but I think starting the 'arguments' on a new line looks better. > + #:make-flags (list > + "CC=3Dgcc" > + (string-append "PREFIX=3D" (assoc-ref %outputs "out"))) > + #:phases (modify-phases %standard-phases > + (delete 'configure)) > + #:tests? #f)) > + (native-inputs `(("libtool", libtool) > + ("ncurses", ncurses) > + ("pkg-config", pkg-config))) Are any of these inputs used at runtime and not just required for building? If so, they should be a regular 'input' and not a 'native-input'. ncurses is usually linked as a library and thus needs to match the target architecture. See the 'package' reference in the Guix manual for more information: https://www.gnu.org/software/guix/manual/guix.html#package-Reference Guix will often automatically detect whether inputs are runtime dependencies. You can run `guix gc -R $(./pre-inst-env guix build libtermkey)` to check which inputs are referenced by the built product. > + (synopsis "Keyboard entry processing libary for terminal-based progr= ams") ^ missing 'r' :-)=20 > + (description > + "Libtermkey handles all the necessary logic to recognise special k= eys, UTF-8 > +combining, and so on, with a simple interface.") > + (home-page "http://www.leonerd.org.uk/code/libtermkey") > + (license expat))) The rest LGTM. Can you send an updated patch for 'terminals.scm' addressing the above points? Thanks! --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAlhGv8EACgkQoqBt8qM6 VPrgqAf/YHRfEOXnIa2YcYqMjtZvYbgnHj0XiCqrSFAn+3/uMaCFywC6FbJ3Y47l yZ4P4R1vdyJa6oUNiGcLFbRu854bcWT2cxdMsytkS84jG0CMJG+ui+KUOpsN4n3L DZzcRoRNtElXTw3UolXAsQo+Pf9Ub24HXjEhGpuZzwQTm+jUNrDNpEzTt34Be/E+ vZl9oEzbUQq3Lpl2hRhV4Xb49EJ4GgtQDGhRS84EYKNffVSuJy89/Bo7qc+7C4xP AapOYtwOgymojDpcvmaEh8pPb2tFrcRDle4M53efFvSNJNI/BcTq6fEaPc7/J/QD VTELlyxo8ZMYCMHuaiUqUKBiEtcROw== =qqAb -----END PGP SIGNATURE----- --=-=-=--