From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: Danny Milosavljevic <dannym@scratchpost.org>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: python-pip: Update to 9.0.1
Date: Mon, 12 Dec 2016 08:37:31 -0800 [thread overview]
Message-ID: <87shptw1bo.fsf@gmail.com> (raw)
In-Reply-To: <20161129235610.236a0cef@scratchpost.org> (Danny Milosavljevic's message of "Tue, 29 Nov 2016 23:56:10 +0100")
Danny Milosavljevic <dannym@scratchpost.org> writes:
> Hi,
>
> On Mon, 28 Nov 2016 17:08:49 -0800
> Maxim Cournoyer <maxim.cournoyer@gmail.com> wrote:
>
>> (inputs
>> - `(("python-setuptools" ,python-setuptools)
>> - ("python-virtualenv" ,python-virtualenv)
>> - ;; Tests
>> - ("python-mock" ,python-mock)
>> - ("python-pytest" ,python-pytest)
>> - ("python-scripttest" ,python-scripttest)))
>> + `(("python-setuptools" ,python-setuptools)
>> + ;; Tests requirements.
>> + ("python-mock" ,python-mock)
>> + ("python-pretend" ,python-pretend)
>> + ("python-pytest" ,python-pytest)
>> + ("python-scripttest" ,python-scripttest)
>> + ("python-virtualenv" ,python-virtualenv)))
>
> Why are the test requirements regular inputs? If they aren't required at runtime, they should be native-inputs.
Hi Danny, and sorry for my delayed answer.
I was under the impression that native-inputs only had meaning when
cross-compiling and that otherwise they were the same. From the guix
manual, section 5.1.1, it says:
The distinction between ‘native-inputs’ and ‘inputs’ is
necessary when considering cross-compilation. When
cross-compiling, dependencies listed in ‘inputs’ are built for
the _target_ architecture; conversely, dependencies listed in
‘native-inputs’ are built for the architecture of the _build_
machine.
But then at section 7.6.5.1 it also says:
Python packages required only at build time—e.g., those listed with
the ‘setup_requires’ keyword in ‘setup.py’—or only for
testing—e.g., those in ‘tests_require’—go into ‘native-inputs’.
The rationale is that (1) they do not need to be propagated because
they are not needed at run time, and (2) in a cross-compilation
context, it’s the “native” input that we’d want.
I stand corrected, thanks! I'll rework the pip package definition and
send a patch later this week, also taking into account the latest
changes to the python build system from Hartmut.
Maxim
next prev parent reply other threads:[~2016-12-12 16:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-29 1:08 [PATCH] gnu: python-pip: Update to 9.0.1 Maxim Cournoyer
2016-11-29 22:56 ` Danny Milosavljevic
2016-12-12 16:37 ` Maxim Cournoyer [this message]
2016-11-30 9:57 ` Hartmut Goebel
2016-12-12 16:41 ` Maxim Cournoyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87shptw1bo.fsf@gmail.com \
--to=maxim.cournoyer@gmail.com \
--cc=dannym@scratchpost.org \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.