From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark H Weaver Subject: Re: Custom kernel Date: Mon, 12 Dec 2016 15:13:07 -0500 Message-ID: <87shps29f0.fsf@netris.org> References: <60c00abf5ceeeb6cfe571991f4969c87@mail.teknik.io> <87d1hafkr7.fsf@gnu.org> <87y3zma72y.fsf@netris.org> <87r35eyv5t.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:42259) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cGWyd-0000Fr-Oi for help-guix@gnu.org; Mon, 12 Dec 2016 15:13:36 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cGWyY-0003uK-M0 for help-guix@gnu.org; Mon, 12 Dec 2016 15:13:35 -0500 In-Reply-To: <87r35eyv5t.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Sun, 11 Dec 2016 23:10:06 +0100") List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: help-guix-bounces+gcggh-help-guix=m.gmane.org@gnu.org Sender: "Help-Guix" To: Ludovic =?utf-8?Q?Court=C3=A8s?= Cc: Dmitri Anikin , help-guix@gnu.org ludo@gnu.org (Ludovic Court=C3=A8s) writes: > Hello! > > Mark H Weaver skribis: > >> ludo@gnu.org (Ludovic Court=C3=A8s) writes: >> >>> Currently =E2=80=98make-linux-libre=E2=80=99 is not public, but we coul= d probably make >>> it public (David, WDYT?). In the meantime, in your own module, you can >>> do: >>> >>> (define make-linux-libre >>> ;; It=E2=80=99s private but I wanna use it anyway! >>> (@@ (gnu packages linux) make-linux-libre)) >> >> I think we should avoid exporting 'make-linux-libre' in its current >> form. > > Makes sense. > >> Although it was an improvement in some ways over what we had >> previously, I've found it to be an inadequate interface in many >> respects, and in my opinion it needs to be redesigned. I don't have >> time to make a case now, but in practice it leads to redundancy. For >> example, when I recently added security fixes to linux-libre, I needed >> to add the patches in two separate places, and every time I update the >> version, I need to update two places as well. > > Looking at 6b2921c3acf2cc808128af97784929365f8582af, it seems that > patches lead to modifications in only one place (the =E2=80=98make-linux-= libre=E2=80=99 > call site), no? If you look more carefully at 6b2921c3acf2cc808128af97784929365f8582af, you'll see that I had to apply the patches in two places, and if we had more kernel variants for other machines, it would have been more than two places. The problem is that there are multiple 'make-linux-libre' call sites for the same kernel version, and each of them needs to be passed various subfields of the 'source'. There's no straightforward way to 'inherit' from a master 'linux-libre' package and then override some of those parameters that are passed to 'make-linux-libre'. Mark