From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marius Bakke Subject: Re: [PATCH] gnu: netcdf: Enable HDF4 support. Date: Sat, 24 Dec 2016 14:54:56 +0100 Message-ID: <87shpdo2j3.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> References: <20161223.162944.1962365172011014380.post@thomasdanckaert.be> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:32996) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cKmmu-0007Qg-45 for guix-devel@gnu.org; Sat, 24 Dec 2016 08:55:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cKmmp-0005xj-Mj for guix-devel@gnu.org; Sat, 24 Dec 2016 08:55:04 -0500 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:41474) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cKmmp-0005xP-IG for guix-devel@gnu.org; Sat, 24 Dec 2016 08:54:59 -0500 In-Reply-To: <20161223.162944.1962365172011014380.post@thomasdanckaert.be> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Thomas Danckaert , guix-devel@gnu.org --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Thomas Danckaert writes: > Hi Guix, > > this patch enables HDF4 support in the netCDF package. > > By the way, I noticed some error messages from doxygen during the=20 > build: > > error: Problems running dot: exit code=3D127, command=3D'dot',=20 > arguments=3D'"/tmp/guix-build-netcdf-4.4.1.1.drv-0/netcdf-4.4.1.1/docs/ht= ml/datt_8c__incl.dot"=20 > -Tpng -o=20 > "/tmp/guix-build-netcdf-4.4.1.1.drv-0/netcdf-4.4.1.1/docs/html/datt_8c__i= ncl.png"' > (these error are already in the present package, for example see=20 > http://hydra.gnu.org/build/1686038/log/raw ). > > These errors don't cause the build to fail, and are related to=20 > html/pdf documentation, which is not installed anyway, as far is I=20 > can see. So perhaps not very critical. > > When I build the package myself in a =E2=80=9Cguix environment netcdf=E2= =80=9D, I=20 > can't reproduce the errors. The above error indicates that the 'dot' command cannot be found during the build process. If it works in `guix environment netcdf`, perhaps you are on a foreign distro and have /usr/bin/dot in your PATH? In any case it should be fixed in a separate patch, and likely only needed for documentation. I've applied this patch, thanks! > From 893ef9ad6bfb8edbe64d64f3ab5d6a0bd4705a5f Mon Sep 17 00:00:00 2001 > From: Thomas Danckaert > Date: Fri, 23 Dec 2016 14:56:00 +0100 > Subject: [PATCH] gnu: netcdf: Enable HDF4 support. > > * gnu/packages/maths.scm (netcdf)[inputs]: Add hdf4-alt and libjpeg. > [arguments]: Add "--enable-hdf4" configure flag. > --- > gnu/packages/maths.scm | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/gnu/packages/maths.scm b/gnu/packages/maths.scm > index e15eddc..d045895 100644 > --- a/gnu/packages/maths.scm > +++ b/gnu/packages/maths.scm > @@ -726,10 +726,12 @@ HDF5 file is encoded according to the HDF File Form= at Specification.") > ("doxygen" ,doxygen) > ("graphviz" ,graphviz))) > (inputs > - `(("hdf5" ,hdf5) > - ("zlib" ,zlib))) > + `(("hdf4" ,hdf4-alt) > + ("hdf5" ,hdf5) > + ("zlib" ,zlib) > + ("libjpeg" ,libjpeg))) > (arguments > - `(#:configure-flags '("--enable-doxygen" "--enable-dot") > + `(#:configure-flags '("--enable-doxygen" "--enable-dot" "--enable-h= df4") > #:parallel-tests? #f)) ;various race conditions > (home-page "http://www.unidata.ucar.edu/software/netcdf/") > (synopsis "Library for scientific data") > --=20 > 2.7.4 --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAlhefjAACgkQoqBt8qM6 VPrqOggAsdO2Iq6vsTfaFqLtUAU96d03u6Y5UVwVdlZyrL7DAIXT9NAShxfegWSx Zc4W3UZI30nGEwf34a8pJyFq5WGwm1g285Xn4VPiTSBXxJrIcYSleYqJ9EsQwh+w cMf12bnGBw1qspRxBBC0NhJ3HHKl5wm7+3Ei3r7gwzV3ButQzoKTK7RwgmefnZrH 6AkmGyAaoJ7q9YDrEPEWnurQ1rfu/3VBX3if7TvsOLs59Mu+DVWfoE2m4LYDTar8 IVbisboGU4CIVCsRu6XGYx01oPJetBugtSVfjL2pJSruD1+ie0YMLzx1aNx9x6BE PppvEoN6aD+oUcco2rSvmz+dyRneqQ== =0wP3 -----END PGP SIGNATURE----- --=-=-=--