[PATCH] gnu: netcdf: Enable HDF4 support.

[PATCH] gnu: netcdf: Enable HDF4 support.

[Thomas Danckaert]

[-- Attachment #1: Type: Text/Plain, Size: 814 bytes --]

Hi Guix,

this patch enables HDF4 support in the netCDF package.

By the way, I noticed some error messages from doxygen during the 
build:

error: Problems running dot: exit code=127, command='dot', 
arguments='"/tmp/guix-build-netcdf-4.4.1.1.drv-0/netcdf-4.4.1.1/docs/html/datt_8c__incl.dot" 
-Tpng -o 
"/tmp/guix-build-netcdf-4.4.1.1.drv-0/netcdf-4.4.1.1/docs/html/datt_8c__incl.png"'
(these error are already in the present package, for example see 
http://hydra.gnu.org/build/1686038/log/raw ).

These errors don't cause the build to fail, and are related to 
html/pdf documentation, which is not installed anyway, as far is I 
can see.  So perhaps not very critical.

When I build the package myself in a “guix environment netcdf”, I 
can't reproduce the errors.

cheers,

Thomas

[-- Attachment #2: 0001-gnu-netcdf-Enable-HDF4-support.patch --]
[-- Type: Text/X-Patch, Size: 1238 bytes --]

From 893ef9ad6bfb8edbe64d64f3ab5d6a0bd4705a5f Mon Sep 17 00:00:00 2001
From: Thomas Danckaert <thomas.danckaert@gmail.com>
Date: Fri, 23 Dec 2016 14:56:00 +0100
Subject: [PATCH] gnu: netcdf: Enable HDF4 support.

* gnu/packages/maths.scm (netcdf)[inputs]: Add hdf4-alt and libjpeg.
  [arguments]: Add "--enable-hdf4" configure flag.
---
 gnu/packages/maths.scm | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/gnu/packages/maths.scm b/gnu/packages/maths.scm
index e15eddc..d045895 100644
--- a/gnu/packages/maths.scm
+++ b/gnu/packages/maths.scm
@@ -726,10 +726,12 @@ HDF5 file is encoded according to the HDF File Format Specification.")
        ("doxygen" ,doxygen)
        ("graphviz" ,graphviz)))
     (inputs
-     `(("hdf5" ,hdf5)
-       ("zlib" ,zlib)))
+     `(("hdf4" ,hdf4-alt)
+       ("hdf5" ,hdf5)
+       ("zlib" ,zlib)
+       ("libjpeg" ,libjpeg)))
     (arguments
-     `(#:configure-flags '("--enable-doxygen" "--enable-dot")
+     `(#:configure-flags '("--enable-doxygen" "--enable-dot" "--enable-hdf4")
        #:parallel-tests? #f))           ;various race conditions
     (home-page "http://www.unidata.ucar.edu/software/netcdf/")
     (synopsis "Library for scientific data")
-- 
2.7.4

Re: [PATCH] gnu: netcdf: Enable HDF4 support.

[Marius Bakke]

[-- Attachment #1: Type: text/plain, Size: 2560 bytes --]

Thomas Danckaert <post@thomasdanckaert.be> writes:

> Hi Guix,
>
> this patch enables HDF4 support in the netCDF package.
>
> By the way, I noticed some error messages from doxygen during the 
> build:
>
> error: Problems running dot: exit code=127, command='dot', 
> arguments='"/tmp/guix-build-netcdf-4.4.1.1.drv-0/netcdf-4.4.1.1/docs/html/datt_8c__incl.dot" 
> -Tpng -o 
> "/tmp/guix-build-netcdf-4.4.1.1.drv-0/netcdf-4.4.1.1/docs/html/datt_8c__incl.png"'
> (these error are already in the present package, for example see 
> http://hydra.gnu.org/build/1686038/log/raw ).
>
> These errors don't cause the build to fail, and are related to 
> html/pdf documentation, which is not installed anyway, as far is I 
> can see.  So perhaps not very critical.
>
> When I build the package myself in a “guix environment netcdf”, I 
> can't reproduce the errors.

The above error indicates that the 'dot' command cannot be found during
the build process. If it works in `guix environment netcdf`, perhaps you
are on a foreign distro and have /usr/bin/dot in your PATH? In any case
it should be fixed in a separate patch, and likely only needed for
documentation.

I've applied this patch, thanks!

> From 893ef9ad6bfb8edbe64d64f3ab5d6a0bd4705a5f Mon Sep 17 00:00:00 2001
> From: Thomas Danckaert <thomas.danckaert@gmail.com>
> Date: Fri, 23 Dec 2016 14:56:00 +0100
> Subject: [PATCH] gnu: netcdf: Enable HDF4 support.
>
> * gnu/packages/maths.scm (netcdf)[inputs]: Add hdf4-alt and libjpeg.
>   [arguments]: Add "--enable-hdf4" configure flag.
> ---
>  gnu/packages/maths.scm | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/gnu/packages/maths.scm b/gnu/packages/maths.scm
> index e15eddc..d045895 100644
> --- a/gnu/packages/maths.scm
> +++ b/gnu/packages/maths.scm
> @@ -726,10 +726,12 @@ HDF5 file is encoded according to the HDF File Format Specification.")
>         ("doxygen" ,doxygen)
>         ("graphviz" ,graphviz)))
>      (inputs
> -     `(("hdf5" ,hdf5)
> -       ("zlib" ,zlib)))
> +     `(("hdf4" ,hdf4-alt)
> +       ("hdf5" ,hdf5)
> +       ("zlib" ,zlib)
> +       ("libjpeg" ,libjpeg)))
>      (arguments
> -     `(#:configure-flags '("--enable-doxygen" "--enable-dot")
> +     `(#:configure-flags '("--enable-doxygen" "--enable-dot" "--enable-hdf4")
>         #:parallel-tests? #f))           ;various race conditions
>      (home-page "http://www.unidata.ucar.edu/software/netcdf/")
>      (synopsis "Library for scientific data")
> -- 
> 2.7.4

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]