From: Marius Bakke <mbakke@fastmail.com>
To: "Danny Milosavljevic" <dannym@scratchpost.org>,
"Ludovic Courtès" <ludo@gnu.org>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: python-click: Fix test failure.
Date: Tue, 17 Jan 2017 20:39:59 +0100 [thread overview]
Message-ID: <87shohbhm8.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> (raw)
In-Reply-To: <20170117203306.3967922b@scratchpost.org>
[-- Attachment #1: Type: text/plain, Size: 653 bytes --]
Danny Milosavljevic <dannym@scratchpost.org> writes:
> Hi Ludo,
>
>> If you know more details, you’re welcome to add them in the comment, but
>> otherwise feel free to push!
>
> Does that mean push to master or to python-tests or to both?
>
> Also, I don't really know more details other than that the test
> framework does autodiscovery and picks up a module for the wrong
> platform (Windows) just because it's there.
I came across this in python-tests as well, and fixed it by executing
"make test" instead of relying on 'setup.py test'.
Pro tip: Check how upstream runs their test, if they have a CI system
(.travis.yml etc).
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]
next prev parent reply other threads:[~2017-01-17 19:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-11 20:18 [PATCH] gnu: python-click: Fix test failure Danny Milosavljevic
2017-01-16 21:20 ` Ludovic Courtès
2017-01-17 19:33 ` Danny Milosavljevic
2017-01-17 19:39 ` Marius Bakke [this message]
2017-01-17 22:50 ` Ludovic Courtès
2017-01-17 23:27 ` Marius Bakke
2017-01-18 21:44 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87shohbhm8.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me \
--to=mbakke@fastmail.com \
--cc=dannym@scratchpost.org \
--cc=guix-devel@gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.