Re: [PATCH 2/2] services: network-manager: Use record for configuration.

[Christopher Baines <mail@cbaines.net>]

[-- Attachment #1: Type: text/plain, Size: 1026 bytes --]

宋文武 <iyzsong@member.fsf.org> writes:

> Christopher Baines <mail@cbaines.net> writes:
>
>> * gnu/services/network-manager.scm (<network-manager-configuration>): New
>> record type.
>> (network-manager-shpeherd-service): Change to use the
>> network-manager-configuration record, rather than a package.  Generate a
>> simple configuration file from the network-manager-configuration record.
>> (network-manager-service-type): Update extensions to take the
>> network-manager-configuration rather than a package.
>> ---
>>  gnu/services/networking.scm | 77 +++++++++++++++++++++++++++++----------------
>>  1 file changed, 50 insertions(+), 27 deletions(-)
>
> Thanks, could you mention the remove of 'network-manager-service' in the
> changelog and update the 'Network Manager' section of manual?

Thanks for your review. I've sent an updated patch now, which includes
the removal of network-manager-service in the commit message (I'm hoping
that is what you meant by changelog), and manual updates.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 962 bytes --]