From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: [PATCH] gnu: dub: Patch pkg-config name. Date: Tue, 07 Feb 2017 15:13:49 +0100 Message-ID: <87shnqay1u.fsf@gnu.org> References: <20170131160017.7991-1-dannym@scratchpost.org> <87bmula6vr.fsf@gnu.org> <20170202203629.14521773@scratchpost.org> <87vasr9q3h.fsf@gnu.org> <20170203183805.30a5fb1f@scratchpost.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:39816) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cb6Wr-0001MO-AW for guix-devel@gnu.org; Tue, 07 Feb 2017 09:13:58 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cb6Wl-00040g-Fx for guix-devel@gnu.org; Tue, 07 Feb 2017 09:13:57 -0500 In-Reply-To: <20170203183805.30a5fb1f@scratchpost.org> (Danny Milosavljevic's message of "Fri, 3 Feb 2017 18:38:05 +0100") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Danny Milosavljevic Cc: guix-devel@gnu.org Hi Danny, Danny Milosavljevic skribis: > On Fri, 03 Feb 2017 17:49:38 +0100 > ludo@gnu.org (Ludovic Court=C3=A8s) wrote: > >> I think =E2=80=98dub-build-system=E2=80=99 could add it as an implicit i= nput, much like >> =E2=80=98gnu-build-system=E2=80=99 adds binutils as an implicit input. > > Okay, but it's directly used only by dub (it its function of building D p= ackages). > > I don't think D packages themselves even know what pkg-config is. > > The ldc 1.1.0 sources don't even mention "pkg-config" once - neither do a= ny of the D packages I tried except gtk-d. That one mentions it in comments= how to invoke gdc (which we didn't package) and rdmd (rdmd source itself d= oesn't mention pkg-config either) - both are in shell expressions like gdc = CoreGL.d `pkg-config gtkd-3 gl --cflags --libs` and rdmd `pkg-config gtkd-3= --cflags` -L-lGL -L-ldl CoreGL.d). No non-comment reference at all. OK. > That said, we could add pkg-config as an implicit input so that if D pack= ages decided to directly use it in the future they'd pick up the same one. Yeah. >> Or we could simply let people add pkg-config as an input when it=E2=80= =99s >> necessary, just like we do for =E2=80=98gnu-build-system=E2=80=99 packag= es. > > dub itself does automatically use pkg-config. > It's as if make always used pkg-config (whether you write "pkg-config" in= to a Makefile or not). > > Also, if pkg-config is not available dub will silently fallback to guessi= ng. It will not fail (and that's bad!). OK. Well I think the conclusion is that (1) we really need to make sure DUB has pkg-config around one way or another, and (2) of all the solutions we discussed, I don=E2=80=99t see one that is significantly =E2=80=9Cbetter= =E2=80=9D than the other (it was worth discussing them though, because in many cases there=E2=80=99s a solution that =E2=80=9Clooks better=E2=80=9D). So I=E2=80=99d say proceed as you prefer. Thanks for taking the time to explain! Ludo=E2=80=99.