From: "Clément Lassieur" <clement@lassieur.org>
To: Marius Bakke <mbakke@fastmail.com>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: prosody: Update to 0.9.12.
Date: Thu, 23 Feb 2017 14:39:33 +0100 [thread overview]
Message-ID: <87shn558mi.fsf@lassieur.org> (raw)
In-Reply-To: <87poi9ghhk.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me>
Marius Bakke <mbakke@fastmail.com> writes:
> Clément Lassieur <clement@lassieur.org> writes:
>
>> * gnu/packages/messaging.scm (prosody): Update to 0.9.12.
>> [inputs]: Change lua5.1-sec-0.5 to lua5.1-sec.
>> * gnu/packages/lua.scm (lua5.1-sec-0.5): Remove it.
>
> Hi Clément,
>
> The patch looks good, but I don't think removing the copyright is
> necessary even if it is effectively a revert of the original
> contribution. The code may have been copy-pasted or otherwised built
> upon, so leaving it is better IMO.
>
> Do you wish to remove it? Otherwise I'll simply drop that line.
Hi Marius,
Ok, then please drop the line :)
Thanks for the review!
Clément
next prev parent reply other threads:[~2017-02-23 13:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-22 19:51 [PATCH] gnu: prosody: Update to 0.9.12 Clément Lassieur
2017-02-23 13:32 ` Marius Bakke
2017-02-23 13:39 ` Clément Lassieur [this message]
2017-02-23 13:47 ` Marius Bakke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87shn558mi.fsf@lassieur.org \
--to=clement@lassieur.org \
--cc=guix-devel@gnu.org \
--cc=mbakke@fastmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.