From: ludo@gnu.org (Ludovic Courtès)
To: Leo Famulari <leo@famulari.name>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 1/2] doc: Symlink daemon start-up files.
Date: Mon, 06 Mar 2017 11:23:27 +0100 [thread overview]
Message-ID: <87shmqvh40.fsf@gnu.org> (raw)
In-Reply-To: <20170305205553.GB2279@jasmine> (Leo Famulari's message of "Sun, 5 Mar 2017 15:55:53 -0500")
Leo Famulari <leo@famulari.name> skribis:
> On Mon, Jan 16, 2017 at 10:49:32AM +0100, Ludovic Courtès wrote:
>> > On Fri, Nov 18, 2016 at 03:31:24PM -0500, Leo Famulari wrote:
>> > I think we should go back to the "old way" of instructing users to copy
>> > the file...
>> >
>> >> I'd argue it should point to /var/guix/profiles/per-user/root/...
>> >
>> > ... and make the service file execute this path.
>>
>> Could you send a patch?
>
> I've attached two patches. The first updates the instructions in the
> manual, and the second builds the service files with the '/var/guix...'
> path.
>
> From 62249ac64fb5cd0235bba28197cb7ac697719b83 Mon Sep 17 00:00:00 2001
> From: Leo Famulari <leo@famulari.name>
> Date: Sun, 5 Mar 2017 14:04:34 -0500
> Subject: [PATCH 1/2] Revert "doc: Symlink daemon start-up files."
>
> This reverts commit b7230de54b493da5a78922b4226255763b525a98.
>
> Versions of systemd that supported symlinked service files are not yet widely
> deployed.
>
> See this thread for more information:
> http://lists.gnu.org/archive/html/guix-devel/2017-01/msg01199.html
Could you add this reference in a @c comment in the .texi file?
Otherwise LGTM!
> From b79385c076ba4921fdf5f3ad2af76d3d171515c8 Mon Sep 17 00:00:00 2001
> From: Leo Famulari <leo@famulari.name>
> Date: Sun, 5 Mar 2017 14:33:13 -0500
> Subject: [PATCH 2/2] build: Don't embed absolute paths in .service and .conf
> service files.
>
> Otherwise, users will be stuck running an old copy of guix and the guix-daemon
> if they copy the service files instead of symlinking them.
>
> * etc/guix-daemon.conf.in, etc/guix-daemon.service.in, etc/guix-publish.conf.in,
> etc/guix-publish.service.in: Expand @localstatedir@ instead of @bindir@.
> * nix/local.mk (etc/guix-%.service, etc/guix-%.conf): Use @localstatedir@
> instead of @bindir@.
OK.
Thanks for addressing this!
Ludo’.
next prev parent reply other threads:[~2017-03-06 10:23 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-18 11:00 [PATCH 0/2] Hartmut Goebel
2016-11-18 11:00 ` [PATCH 1/2] doc: Symlink daemon start-up files Hartmut Goebel
2016-11-18 20:31 ` Leo Famulari
2016-11-21 16:38 ` Hartmut Goebel
2017-01-15 18:23 ` Leo Famulari
2017-01-15 19:23 ` Marius Bakke
2017-01-16 9:49 ` Ludovic Courtès
2017-03-05 20:55 ` Leo Famulari
2017-03-06 9:10 ` Hartmut Goebel
2017-03-06 10:23 ` Ludovic Courtès [this message]
2017-01-16 10:02 ` Hartmut Goebel
2016-11-18 11:00 ` [PATCH 2/2] Add system start-up files for "guix publish" Hartmut Goebel
2016-11-18 20:35 ` Leo Famulari
2016-11-21 8:52 ` Ludovic Courtès
2016-11-21 17:17 ` Hartmut Goebel
2016-11-18 20:36 ` [PATCH 0/2] Leo Famulari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87shmqvh40.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=guix-devel@gnu.org \
--cc=leo@famulari.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.