bug#26268: [PATCH] gnu: Add emacs-idle-highlight.

bug#26268: [PATCH] gnu: Add emacs-idle-highlight.

[Alex Kost]

Vasile Dumitrascu (2017-03-27 01:39 +0200) wrote:

Hello Vasile!

>     * gnu/packages/emacs.scm (emacs-idle-highlight): New variable.
> ---
>  gnu/packages/emacs.scm | 21 +++++++++++++++++++++
>  1 file changed, 21 insertions(+)
>
> diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
> index 4fe2ffa4d..02f92bc26 100644
> --- a/gnu/packages/emacs.scm
> +++ b/gnu/packages/emacs.scm
> @@ -3960,3 +3960,24 @@ abbreviation and automatically expand it into function templates.")
>     (description "@code{emacs-memoize} is an Emacs library for
>  memoizing functions.")
>     (license license:unlicense)))
> +
> +(define-public emacs-idle-highlight
> +  (package
> +    (name "emacs-idle-highlight")
> +    (version "20120920.948")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append
> +             "http://melpa.org/packages/idle-highlight-mode-"
> +             version ".el"))

We don't (at least we shouldn't IMO) use files from MELPA.  The problem
is: once the original source will be updated on github, MELPA will build
it and the previous MELPA version will not be available anymore.

So I think it's better to use the original source which is:

  https://github.com/nonsequitur/idle-highlight-mode/archive/1.1.3.tar.gz

Could you send an updated patch with this tarball?

Sorry, I missed your previous emacs packages (symon, monroe and
keyfreq), which are committed already, but eventually they will become
"broken": for example, when there will be a new commit in "monroe"
repository, MELPA will build the new version and the current
"monroe-20170220.540.el" file will be removed from MELPA, so the current
'emacs-monroe' package could never be built after that.

The situation was much worse in the past, when MELPA updated even
untouched(!) packages every several hours, so their hashes were changing
all the time, so the files from MELPA couldn't be used at all.
Nowadays, MELPA updates packages only when there are some changes in the
source.

> +       (sha256
> +        (base32
> +         "083ihf97a20l9pbqgn9jh6vdx97z40mp2fhi17qs90a16hpfhx5j"))))
> +    (build-system emacs-build-system)
> +    (home-page "http://www.emacswiki.org/cgi-bin/wiki/IdleHighlight")

For me it is redirected to
<https://www.emacswiki.org/emacs/IdleHighlight> so I think it's better
to use this page.

> +    (synopsis "Highlights all occurences of the word the point is on")
> +    (description
> +     "@code{idle-highlight-mode} sets an idle timer that highlights all
> +occurences in the buffer of the word under the point.")

Usually we mention "Emacs" in synopsis or description, like:

"This Emacs package provides @code{idle-highlight-mode} that sets an
idle timer to highlight all occurences in the buffer of the word under
the point."

> +    (license license:gpl3+)))

-- 
Alex

bug#26268: [PATCH] gnu: Add emacs-idle-highlight.

[Vasile Dumitrascu]

    Hi Alex

  I agree with your observations. To explain my previous choice: I was
using melpa as source for the packages as I have found the option to
import from melpa in
https://www.gnu.org/software/guix/manual/guix.html#Invoking-guix-import
so I thought that this is the recommended approach. The document should
be updated to mention this as not recommended for contributions, for the
reasons you have mentioned.

  Maybe rather we should have a predefined import task that easily
imports from github or git based repositories (I could not find one in
the docs).

  I will make the changes for this and the previous submitted packages
and refile patches. Thank you,

   Vasile

Alex Kost:
> Vasile Dumitrascu (2017-03-27 01:39 +0200) wrote:
> 
> Hello Vasile!
> 
>>     * gnu/packages/emacs.scm (emacs-idle-highlight): New variable.
>> ---
>>  gnu/packages/emacs.scm | 21 +++++++++++++++++++++
>>  1 file changed, 21 insertions(+)
>>
>> diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
>> index 4fe2ffa4d..02f92bc26 100644
>> --- a/gnu/packages/emacs.scm
>> +++ b/gnu/packages/emacs.scm
>> @@ -3960,3 +3960,24 @@ abbreviation and automatically expand it into function templates.")
>>     (description "@code{emacs-memoize} is an Emacs library for
>>  memoizing functions.")
>>     (license license:unlicense)))
>> +
>> +(define-public emacs-idle-highlight
>> +  (package
>> +    (name "emacs-idle-highlight")
>> +    (version "20120920.948")
>> +    (source
>> +     (origin
>> +       (method url-fetch)
>> +       (uri (string-append
>> +             "http://melpa.org/packages/idle-highlight-mode-"
>> +             version ".el"))
> 
> We don't (at least we shouldn't IMO) use files from MELPA.  The problem
> is: once the original source will be updated on github, MELPA will build
> it and the previous MELPA version will not be available anymore.
> 
> So I think it's better to use the original source which is:
> 
>   https://github.com/nonsequitur/idle-highlight-mode/archive/1.1.3.tar.gz
> 
> Could you send an updated patch with this tarball?
> 
> Sorry, I missed your previous emacs packages (symon, monroe and
> keyfreq), which are committed already, but eventually they will become
> "broken": for example, when there will be a new commit in "monroe"
> repository, MELPA will build the new version and the current
> "monroe-20170220.540.el" file will be removed from MELPA, so the current
> 'emacs-monroe' package could never be built after that.
> 
> The situation was much worse in the past, when MELPA updated even
> untouched(!) packages every several hours, so their hashes were changing
> all the time, so the files from MELPA couldn't be used at all.
> Nowadays, MELPA updates packages only when there are some changes in the
> source.
> 
>> +       (sha256
>> +        (base32
>> +         "083ihf97a20l9pbqgn9jh6vdx97z40mp2fhi17qs90a16hpfhx5j"))))
>> +    (build-system emacs-build-system)
>> +    (home-page "http://www.emacswiki.org/cgi-bin/wiki/IdleHighlight")
> 
> For me it is redirected to
> <https://www.emacswiki.org/emacs/IdleHighlight> so I think it's better
> to use this page.
> 
>> +    (synopsis "Highlights all occurences of the word the point is on")
>> +    (description
>> +     "@code{idle-highlight-mode} sets an idle timer that highlights all
>> +occurences in the buffer of the word under the point.")
> 
> Usually we mention "Emacs" in synopsis or description, like:
> 
> "This Emacs package provides @code{idle-highlight-mode} that sets an
> idle timer to highlight all occurences in the buffer of the word under
> the point."
> 
>> +    (license license:gpl3+)))
> 

bug#26268: [PATCH] gnu: Add emacs-idle-highlight.

[Ludovic Courtès]

Hi Vasile,

Vasile Dumitrascu <va511e@yahoo.com> skribis:

>   I agree with your observations. To explain my previous choice: I was
> using melpa as source for the packages as I have found the option to
> import from melpa in
> https://www.gnu.org/software/guix/manual/guix.html#Invoking-guix-import
> so I thought that this is the recommended approach. The document should
> be updated to mention this as not recommended for contributions, for the
> reasons you have mentioned.
>
>   Maybe rather we should have a predefined import task that easily
> imports from github or git based repositories (I could not find one in
> the docs).

You’re right, there’s no such thing.

The difficulty here is that the importer gets package info from
melpa.org (or elpa.gnu.org) and AIUI, this info does not include the URL
of the upstream repo.  That’s why we have to do that step manually,
which is arguably suboptimal.

Not sure how to improve it.

Thoughts?

Ludo’.

bug#26268: [PATCH] gnu: Add emacs-idle-highlight.

[Vasile Dumitrascu]

* gnu/packages/emacs.scm (emacs-idle-highlight): New variable.
---
 gnu/packages/emacs.scm | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index 1becc28dd..358748cbf 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -3962,3 +3962,26 @@ abbreviation and automatically expand it into function templates.")
    (description "@code{emacs-memoize} is an Emacs library for
 memoizing functions.")
    (license license:unlicense)))
+
+(define-public emacs-idle-highlight
+  (package
+    (name "emacs-idle-highlight")
+    (version "1.1.3")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "https://github.com/nonsequitur/idle-highlight-mode/archive/"
+             version ".tar.gz"))
+       (file-name (string-append name "-" version ".tar.gz"))
+       (sha256
+        (base32
+         "0kdv10hrgqpskjh0zvpnzwlkn5bccnqxas62gkws6njln57bf8nl"))))
+    (build-system emacs-build-system)
+    (home-page "https://www.emacswiki.org/emacs/IdleHighlight")
+    (synopsis "Highlights all occurences of the word the point is on")
+    (description
+     "This Emacs package provides @code{idle-highlight-mode} that sets
+ an idle timer to highlight all occurences in the buffer of the word under
+ the point.")
+    (license license:gpl3+)))
-- 
2.11.0

bug#26268: [PATCH] gnu: Add emacs-idle-highlight.

[Catonano]

[-- Attachment #1: Type: text/plain, Size: 2427 bytes --]

Hi Vasile,

2017-03-28 22:12 GMT+02:00 Vasile Dumitrascu <va511e@yahoo.com>:

> * gnu/packages/emacs.scm (emacs-idle-highlight): New variable.
> ---
>  gnu/packages/emacs.scm | 23 +++++++++++++++++++++++
>  1 file changed, 23 insertions(+)
>
> diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
> index 1becc28dd..358748cbf 100644
> --- a/gnu/packages/emacs.scm
> +++ b/gnu/packages/emacs.scm
> @@ -3962,3 +3962,26 @@ abbreviation and automatically expand it into
> function templates.")
>     (description "@code{emacs-memoize} is an Emacs library for
>  memoizing functions.")
>     (license license:unlicense)))
> +
> +(define-public emacs-idle-highlight
> +  (package
> +    (name "emacs-idle-highlight")
> +    (version "1.1.3")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append
> +             "https://github.com/nonsequitur/idle-highlight-mode/archive/
> "
> +             version ".tar.gz"))
> +       (file-name (string-append name "-" version ".tar.gz"))
> +       (sha256
> +        (base32
> +         "0kdv10hrgqpskjh0zvpnzwlkn5bccnqxas62gkws6njln57bf8nl"))))
> +    (build-system emacs-build-system)
> +    (home-page "https://www.emacswiki.org/emacs/IdleHighlight")
> +    (synopsis "Highlights all occurences of the word the point is on")
> +    (description
> +     "This Emacs package provides @code{idle-highlight-mode} that sets
> + an idle timer to highlight all occurences in the buffer of the word under
> + the point.")
> +    (license license:gpl3+))
>

After the correction with the github url, I installed this package and it
works. It beautifully highlights words occurrences

So, as far as I'm concerned, this can be merged.

As a side note, you sent some one more patch after this one and that
depends on this one so it can't be applied

After that you sent a couple more in the same way

This requires the reviewers to reconstruct the chain in order to apply the
patches.

For the future, it would be preferable if you would send a first message to
guix-patches to open a ticket and then reply to that first message with
your patches attached.

Alternatively, you can use this command line (suggested by Marius Bakke):

git format-patch -n origin/master --stdout > series.patch

in this way, ALL the patches in your branch will be contained in a single
file (series.patch)

You can send that single file to guix-patches

Thank you and welcome !

[-- Attachment #2: Type: text/html, Size: 3590 bytes --]

bug#26268: [PATCH] gnu: Add emacs-idle-highlight.

[Vasile Dumitrascu]

  Hi

I will keep in mind your recommendation in the future. Thanks,

  Vasile

Catonano:
> Hi Vasile,
> 
> 2017-03-28 22:12 GMT+02:00 Vasile Dumitrascu <va511e@yahoo.com>:
> 
>> * gnu/packages/emacs.scm (emacs-idle-highlight): New variable.
>> ---
>>  gnu/packages/emacs.scm | 23 +++++++++++++++++++++++
>>  1 file changed, 23 insertions(+)
>>
>> diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
>> index 1becc28dd..358748cbf 100644
>> --- a/gnu/packages/emacs.scm
>> +++ b/gnu/packages/emacs.scm
>> @@ -3962,3 +3962,26 @@ abbreviation and automatically expand it into
>> function templates.")
>>     (description "@code{emacs-memoize} is an Emacs library for
>>  memoizing functions.")
>>     (license license:unlicense)))
>> +
>> +(define-public emacs-idle-highlight
>> +  (package
>> +    (name "emacs-idle-highlight")
>> +    (version "1.1.3")
>> +    (source
>> +     (origin
>> +       (method url-fetch)
>> +       (uri (string-append
>> +             "https://github.com/nonsequitur/idle-highlight-mode/archive/
>> "
>> +             version ".tar.gz"))
>> +       (file-name (string-append name "-" version ".tar.gz"))
>> +       (sha256
>> +        (base32
>> +         "0kdv10hrgqpskjh0zvpnzwlkn5bccnqxas62gkws6njln57bf8nl"))))
>> +    (build-system emacs-build-system)
>> +    (home-page "https://www.emacswiki.org/emacs/IdleHighlight")
>> +    (synopsis "Highlights all occurences of the word the point is on")
>> +    (description
>> +     "This Emacs package provides @code{idle-highlight-mode} that sets
>> + an idle timer to highlight all occurences in the buffer of the word under
>> + the point.")
>> +    (license license:gpl3+))
>>
> 
> After the correction with the github url, I installed this package and it
> works. It beautifully highlights words occurrences
> 
> So, as far as I'm concerned, this can be merged.
> 
> As a side note, you sent some one more patch after this one and that
> depends on this one so it can't be applied
> 
> After that you sent a couple more in the same way
> 
> This requires the reviewers to reconstruct the chain in order to apply the
> patches.
> 
> For the future, it would be preferable if you would send a first message to
> guix-patches to open a ticket and then reply to that first message with
> your patches attached.
> 
> Alternatively, you can use this command line (suggested by Marius Bakke):
> 
> git format-patch -n origin/master --stdout > series.patch
> 
> in this way, ALL the patches in your branch will be contained in a single
> file (series.patch)
> 
> You can send that single file to guix-patches
> 
> Thank you and welcome !
> 

bug#26268: [PATCH] gnu: Add emacs-idle-highlight.

[Ludovic Courtès]

Vasile Dumitrascu <va511e@yahoo.com> skribis:

> * gnu/packages/emacs.scm (emacs-idle-highlight): New variable.

AFAICS this addresses Alex’s concerns so I’ve applied it, thanks!

Ludo’.