From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41092)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1d0AQb-0001IQ-UZ
	for guix-patches@gnu.org; Mon, 17 Apr 2017 13:27:11 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1d0AQY-00042K-Qu
	for guix-patches@gnu.org; Mon, 17 Apr 2017 13:27:05 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:54621)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1d0AQY-00042E-Mu
	for guix-patches@gnu.org; Mon, 17 Apr 2017 13:27:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1d0AQY-0004Cu-H3
	for guix-patches@gnu.org; Mon, 17 Apr 2017 13:27:02 -0400
Subject: bug#26544: [PATCH] system: Move "--load" and other guix-specific
	parameters from the grub module to the generic system module.
Resent-Message-ID: <handler.26544.B26544.149245000916153@debbugs.gnu.org>
References: <20170417170030.2212-1-dannym@scratchpost.org>
From: Mathieu Othacehe <m.othacehe@gmail.com>
In-reply-to: <20170417170030.2212-1-dannym@scratchpost.org>
Date: Mon, 17 Apr 2017 19:26:39 +0200
Message-ID: <87shl7aqsw.fsf@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Danny Milosavljevic <dannym@scratchpost.org>
Cc: 26544@debbugs.gnu.org


Hi Danny,

I'll review it more carefully tomorrow, but here are first comments :

> +  (mlet* %store-monad ( ;(initrd   (operating-system-initrd-file os))

Commented lines.

> +                       (root ->  (operating-system-root-file-system os))
> +                       ;(store -> (operating-system-store-file-system os))
> +                       ;(label -> (kernel->boot-label
> +                       ;           (operating-system-kernel os)))
> +                       (params (operating-system-boot-parameters os system (file-system-device root))))

This line is way over 80 chars.

Thanks,

Mathieu