From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44107)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dCj8I-0006YF-3b
	for guix-patches@gnu.org; Mon, 22 May 2017 04:56:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dCj8F-0000M9-14
	for guix-patches@gnu.org; Mon, 22 May 2017 04:56:06 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:57309)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1dCj8E-0000M4-M5
	for guix-patches@gnu.org; Mon, 22 May 2017 04:56:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dCj8E-0000j5-Fo
	for guix-patches@gnu.org; Mon, 22 May 2017 04:56:02 -0400
Subject: bug#26966: [PATCH 06/22] gnu: Add ecj-javac-wrapper.
Resent-Message-ID: <handler.26966.B26966.14954433192740@debbugs.gnu.org>
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
References: <20170517171905.7840-1-rekado@elephly.net>
	<20170517171905.7840-6-rekado@elephly.net> <rbuefvhs5mb.fsf@gnu.org>
Date: Mon, 22 May 2017 10:55:06 +0200
In-Reply-To: <rbuefvhs5mb.fsf@gnu.org> (Roel Janssen's message of "Mon, 22 May
	2017 09:38:52 +0200")
Message-ID: <87shjxw9sl.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Roel Janssen <roel@gnu.org>
Cc: Ricardo Wurmus <rekado@elephly.net>, 26966@debbugs.gnu.org

Hi!

Roel Janssen <roel@gnu.org> skribis:

>> +           (with-output-to-file target
>> +             (lambda _
>> +               (format #t "#!~a --no-auto-compile\n!#\n" guile)
>> +               (map write
>> +                    `((use-modules (ice-9 match)
>> +                                   (ice-9 receive)
>> +                                   (ice-9 hash-table)
>> +                                   (srfi srfi-1)
>> +                                   (srfi srfi-26))
>> +                      (define defaults
>> +                        '(("-bootclasspath" ,bootcp)
>> +                          ("-source" "1.5")
>> +                          ("-target" "1.5")
>> +                          ("-cp"     ".")))

Minor nitpick: I would rather write this as

  (write `(begin
            (use-modules =E2=80=A6)
            (define =E2=80=A6)
            =E2=80=A6)
          port)

because (1) =E2=80=98map=E2=80=99 returns a list of values, so =E2=80=98for=
-each=E2=80=99 would be more
appropriate, and (2) I think sexps should be considered as a whole
rather than as a list of sexps in general.

Ludo=E2=80=99.