From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57437) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dFoTp-0001Ng-R1 for guix-patches@gnu.org; Tue, 30 May 2017 17:15:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dFoTm-0000oR-Kx for guix-patches@gnu.org; Tue, 30 May 2017 17:15:05 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:43110) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dFoTm-0000oN-Hc for guix-patches@gnu.org; Tue, 30 May 2017 17:15:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dFoTm-0005nR-CV for guix-patches@gnu.org; Tue, 30 May 2017 17:15:02 -0400 Subject: bug#26970: plymouth Resent-Message-ID: References: <20170517195112.cun2swywlwe75fsp@abyayala> From: Ricardo Wurmus In-reply-to: <20170517195112.cun2swywlwe75fsp@abyayala> Date: Tue, 30 May 2017 23:14:11 +0200 Message-ID: <87shjm2gkc.fsf@elephly.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: ng0 Cc: 26970@debbugs.gnu.org > Subject: [PATCH] gnu: Add plymouth. > > * gnu/packages/freedesktop.scm (plymouth): New variable. > --- Thanks! […] > + (arguments > + `(#:configure-flags (list (string-append "--sbindir=" > + (assoc-ref %outputs "out") > + "/sbin") > + (string-append "--bindir=" > + (assoc-ref %outputs "out") > + "/bin") > + (string-append "--prefix=" > + (assoc-ref %outputs "out")) > + (string-append "--exec-prefix=" > + (assoc-ref %outputs "out")) > + (string-append "--libexecdir=" > + (assoc-ref %outputs "out") > + "/lib") Is it really necessary to set *all* of these? Usually it’s sufficient to just set “--prefix” and that’s done by default. > + (string-append "--sysconfdir=" > + "/etc") You don’t need string-append here. Is it *necessary* to use the global /etc here, or can it be told (at runtime) to read its configuration files from elsewhere? > + (string-append "--localstatedir=" > + "/var") > + (string-append "--with-logo=" > + "/etc/plymouth/logo.png") I would prefer if we didn’t have to use the global /etc here. You don’t need string-append here. > + (string-append "--with-background-color=" > + "0x000000") > + (string-append "--with-background-start-color-stop=" > + "0x000000") > + (string-append "--with-background-end-color-stop=" > + "0x000000") Why are these provided? > + "--without-system-root-install" > + "--without-rhgb-compat-link" > + "--enable-tracing" > + "--disable-systemd-integration" > + "--enable-pango" > + "--enable-gdm-transition" > + "--enable-gtk") And what about these? Does “disable-systemd-integration” mean that it won’t work with elogind? > + #:make-flags (list (string-append "plymouthd_defaultsdir=" > + (assoc-ref %outputs "out") > + "/share/plymouth") > + (string-append "plymouthd_confdir=" > + (assoc-ref %outputs "out") > + "/etc/plymouth")) These differ from the configure flags above that say that the global /etc should be used. Is this on purpose? > + #:phases > + (modify-phases %standard-phases > + (add-before 'configure 'fix-docbook > + (lambda* (#:key inputs #:allow-other-keys) > + (substitute* "docs/Makefile.in" > + (("http://docbook.sourceforge.net/release/xsl/current/manpages/docbook.xsl") > + (string-append (assoc-ref inputs "docbook-xsl") > + "/xml/xsl/docbook-xsl-" > + ,(package-version docbook-xsl) > + "/manpages/docbook.xsl"))) > + (setenv "XML_CATALOG_FILES" > + (string-append (assoc-ref inputs "docbook-xml") > + "/xml/dtd/docbook/catalog.xml")) > + #t))))) > + (inputs > + `(("gtk+" ,gtk+) > + ("glib" ,glib) > + ("cairo" ,cairo) > + ("libdrm" ,libdrm) > + ("pango" ,pango) > + ("libpng" ,libpng) > + ("eudev" ,eudev))) > + (native-inputs > + `(("pkg-config" ,pkg-config) > + ("libxslt" ,libxslt) > + ("docbook-xsl" ,docbook-xsl) > + ("docbook-xml" ,docbook-xml))) > + (synopsis "Graphical boot animation (splash) and logger") > + (home-page "https://www.freedesktop.org/wiki/Software/Plymouth/") > + (description > + "Plymouth is an application that runs very early in the boot > +process (even before the root filesystem is mounted!) that provides “and” ——————————————^ > +a graphical boot animation while the boot process happens in the > +background. I wonder how this will work “before the root filesystem is mounted” when the store actually sits on the root filesystem. I would prefer to only add this once it actually works, so I’d very much like to see a proof of concept for how to use it in a system. -- Ricardo GPG: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC https://elephly.net