all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Alex Kost <alezost@gmail.com>
To: Oleg Pykhalov <go.wigust@gmail.com>
Cc: 27302-done@debbugs.gnu.org
Subject: bug#27302: emacs-dired-hacks-utils in one patch with github origin
Date: Sat, 24 Jun 2017 22:04:55 +0300	[thread overview]
Message-ID: <87shipfbqg.fsf@gmail.com> (raw)
In-Reply-To: <87k242ndsd.fsf_-_@gmail.com> (Oleg Pykhalov's message of "Sat, 24 Jun 2017 08:41:06 +0300")

Oleg Pykhalov (2017-06-24 08:41 +0300) wrote:

> Hi Alex,
>
> Alex Kost <alezost@gmail.com> writes:
>
>> Unfortunately, we can't use sources from MELPA.  The problem is: when a
>> repository get a new commit, the old tarball is *REPLACED* with the new
>> one on MELPA, so the package could never be built anymore, since the
>> source disappeared.  That's why we use tarballs directly from source.
>
> OK.  I saw some melpa packages in emacs.scm though.  Will they be
> removed in future?

I see the only package that uses MELPA source ("emacs-keyfreq"), and it
was definitely done so by mistake.  It will not be removed, instead it
should be adjusted to use a source directly from the upstream which is:

  https://github.com/dacap/keyfreq/archive/1.8.tar.gz

>> I see that this "dired-hacks" repository is split into multiple packages
>> on MELPA, and you follow this path, however I think it would be much
>> easier for us just to have a single "emacs-dired-hacks" package.
>> Otherwise, we'll have to pick single files for all these "dired-open",
>> "dired-avfs" and other packages, which is not convenient.
>>
>> What do you think?  Are there any objections on making a single
>> "dired-hacks" package?
>
> I'm not sure if splitting is worth.  I use only dired-open from this
> project.  So, I cannot be sure about other addons.  For example, I have
> some warnings and errors while building full addons collection but
> dired-open works though.

Oh, most of those warnings (like "function is not known to be defined"
or "reference to free variable") are the usual warnings that should be
fixed by the maintainer.  These warnings are harmless, most maintainers
don't even bother to fix them.  And the errors come from missing
libraries: "emacs-s" and "emacs-f" are needed for some files.

As for splitting this package into multiple ones, I think it may be done
in future, if someone will have a wish to do it :-)

[...]
> From 1a22aef22f0eec6c9dd8dc9a20964e11700834d7 Mon Sep 17 00:00:00 2001
> From: Oleg Pykhalov <go.wigust@gmail.com>
> Date: Sat, 10 Jun 2017 02:59:25 +0300
> Subject: [PATCH] gnu: Add emacs-dired-hacks-utils.

Thank you, I added a copyright line for you, adjusted the package recipe
a bit, and committed:

  http://git.savannah.gnu.org/cgit/guix.git/commit/?id=730c0790fc5b3285cd0f1983804e2d76c37cb542

Thanks for contributing!

-- 
Alex

      reply	other threads:[~2017-06-24 19:06 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-10  1:05 bug#27302: [PATCH 1/2] gnu: Add emacs-dired-hacks-utils Oleg Pykhalov
2017-06-10  1:05 ` bug#27302: [PATCH 2/2] gnu: Add emacs-dired-open Oleg Pykhalov
2017-06-10  2:02 ` bug#27302: [PATCH 1/3] gnu: emacs-dired-hacks-utils: Change origin to melpa Oleg Pykhalov
2017-06-10  2:02   ` bug#27302: [PATCH 2/3] gnu: emacs-dired-hacks-utils: Rename define-public Oleg Pykhalov
2017-06-10  2:02   ` bug#27302: [PATCH 3/3] gnu: emacs-dired-open: " Oleg Pykhalov
2017-06-16 12:38   ` [bug#27302] [PATCH 1/3] gnu: emacs-dired-hacks-utils: Change origin to melpa Alex Kost
2017-06-16 12:38 ` [bug#27302] [PATCH 1/2] gnu: Add emacs-dired-hacks-utils Alex Kost
2017-06-22 20:02   ` Ludovic Courtès
2017-06-23 18:55     ` Alex Kost
2017-06-24  5:41       ` [bug#27302] emacs-dired-hacks-utils in one patch with github origin Oleg Pykhalov
2017-06-24 19:04         ` Alex Kost [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87shipfbqg.fsf@gmail.com \
    --to=alezost@gmail.com \
    --cc=27302-done@debbugs.gnu.org \
    --cc=go.wigust@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.