From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50607)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dcAwU-0008Il-9i
	for guix-patches@gnu.org; Mon, 31 Jul 2017 09:41:07 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dcAwQ-0001jT-HR
	for guix-patches@gnu.org; Mon, 31 Jul 2017 09:41:06 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:60440)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1dcAwQ-0001jI-Dn
	for guix-patches@gnu.org; Mon, 31 Jul 2017 09:41:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dcAwQ-0002AL-72
	for guix-patches@gnu.org; Mon, 31 Jul 2017 09:41:02 -0400
Subject: [bug#27865] [PATCH 2/3] pull: Fetch source code from Git.
Resent-Message-ID: <handler.27865.B27865.15015084388289@debbugs.gnu.org>
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
References: <20170728204539.21879-1-ludo@gnu.org>
	<20170728204539.21879-2-ludo@gnu.org> <87r2wy83rq.fsf@gmail.com>
	<8760e9fync.fsf@gnu.org> <87h8xtnfac.fsf@gmail.com>
Date: Mon, 31 Jul 2017 15:40:25 +0200
In-Reply-To: <87h8xtnfac.fsf@gmail.com> (Mathieu Othacehe's message of "Mon,
	31 Jul 2017 11:09:47 +0200")
Message-ID: <87shhc67xy.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Mathieu Othacehe <m.othacehe@gmail.com>
Cc: 27865@debbugs.gnu.org

Howdy Mathieu,

Mathieu Othacehe <m.othacehe@gmail.com> skribis:

> From 6d6b0e48856998251284539e69bbc39e6d21635f Mon Sep 17 00:00:00 2001
> From: Mathieu Othacehe <m.othacehe@gmail.com>
> Date: Mon, 31 Jul 2017 11:08:32 +0200
> Subject: [PATCH] base: Report git errors.
>
> * src/cuirass/base.scm (report-git-error): New procedure.
> (with-git-error-handling): New macro.
> (process-specs): Use with-git-error-handling to catch and report git erro=
rs.
> * build-aux/guix.scm (package)[inputs]: Add guile-git.
> * configure.ac: Check for (git) module. Also check that (git) exports
> git-error-message procedure.

[...]

> +(define (report-git-error error)
> +  "Report the given Guile-Git error."
> +  (format #t "Git error: ~a~%" (git-error-message error)))

s/#t/(current-error-port)/

Otherwise LGTM!

Thanks,
Ludo=E2=80=99.