From mboxrd@z Thu Jan 1 00:00:00 1970 From: Roel Janssen Subject: Re: IcedTea is not linking correctly with libjvm.so Date: Mon, 30 Oct 2017 11:22:02 +0100 Message-ID: <87she1j5px.fsf@gnu.org> References: <87y3o56kve.fsf@gnu.org> <877evokzir.fsf@gmail.com> <87mv4jqirt.fsf@gnu.org> <87fuaa536t.fsf@gmail.com> <87bmkwu61j.fsf@gnu.org> <87she8d6s7.fsf@elephly.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:40659) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e97Cy-0003lI-0R for guix-devel@gnu.org; Mon, 30 Oct 2017 06:22:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e97Cu-0006xc-TL for guix-devel@gnu.org; Mon, 30 Oct 2017 06:22:16 -0400 In-reply-to: <87she8d6s7.fsf@elephly.net> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Ricardo Wurmus Cc: guix-devel Ricardo Wurmus writes: > Roel Janssen writes: > >> gnu/packages/java.scm | 12 ++++++++++++ >> 1 file changed, 12 insertions(+) >> >> diff --git a/gnu/packages/java.scm b/gnu/packages/java.scm >> index 95fba20e8..81cfdc132 100644 >> --- a/gnu/packages/java.scm >> +++ b/gnu/packages/java.scm >> @@ -1404,6 +1404,18 @@ bootstrapping purposes.") >> (copy-recursively "openjdk.build/j2re-image" jre) >> (copy-recursively "openjdk.build/j2sdk-image" jdk)) >> #t)) >> + ;; Some of the libraries in the lib/amd64 folder link to libjvm.so. But that >> + ;; shared object is located in the server/ folder, so it cannot be found. >> + ;; This phase creates a symbolic link in the lib/amd64 folder so that the >> + ;; other libraries can find it. >> + ;; >> + ;; See https://lists.gnu.org/archive/html/guix-devel/2017-10/msg00169.html >> + (add-after 'install 'install-libjvm >> + (lambda* (#:key inputs outputs #:allow-other-keys) >> + (let* ((lib-path (string-append (assoc-ref outputs "out") "/lib/amd64"))) >> + (system* "ln" "--symbolic" >> + (string-append lib-path "/server/libjvm.so") >> + (string-append lib-path "/libjvm.so"))))) > > Please use (symlink foo bar) instead of calling the “ln” tool. Also end > the phase with #t. > > Other than that I think it’s fine as a workaround. Please also add a > FIXME to the comment, so that we can revisit this later. > > Thanks! I used (symlink ...), added a FIXME, rebuilt to see if it worked, and pushed in 491dc2fb1. Thanks! Kind regards, Roel Janssen