[bug#29096] [PATCH] gnu: Add Epson escpr printer driver.

[bug#29096] [PATCH] gnu: Add Epson escpr printer driver.

[Diego Nicola Barbato]

[-- Attachment #1: Type: text/plain, Size: 51 bytes --]

This patch adds the Epson ESC/P-R printer driver.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-Add-Epson-escpr-printer-driver.patch --]
[-- Type: text/x-patch, Size: 2247 bytes --]

From 5d6449cc3cfc4154fff24abcdd54c05b44b9e471 Mon Sep 17 00:00:00 2001
From: Diego Nicola Barbato <dnbarbato@posteo.de>
Date: Wed, 1 Nov 2017 02:48:14 +0100
Subject: gnu: Add Epson escpr printer driver.

* gnu/packages/cups.scm (escpr): New variable.
---
 gnu/packages/cups.scm | 32 ++++++++++++++++++++++++++++++++
 1 file changed, 32 insertions(+)

diff --git a/gnu/packages/cups.scm b/gnu/packages/cups.scm
index 491668e52..54a93fe49 100644
--- a/gnu/packages/cups.scm
+++ b/gnu/packages/cups.scm
@@ -599,3 +599,35 @@ printer/driver specific, but spooler-independent PPD file.")
 protocols, which cover printers made by Konica, HP (LaserJet), Oki, Samsung,
 and more.  See @file{README} for details.")
     (license license:gpl2+)))
+
+(define-public escpr
+  (package
+    (name "escpr")
+    (version "1.6.17")
+    ;; This currently works.  But it will break as soon as a newer
+    ;; version is available since the URLs for older versions are not
+    ;; preserved.  An alternative source will be added as soon as
+    ;; available.
+    (source (origin
+              (method url-fetch)
+              ;; The uri has to be chopped up in order to satisfy guix lint.
+              (uri (string-append "https://download3.ebz.epson.net/dsc/f/03/00/06/66/09/"
+                                  "4ac2bf69bb1ddf4a9ad525596615cbb40fe4dad5/"
+                                  "epson-inkjet-printer-escpr-1.6.17-1lsb3.2.tar.gz"))
+              (sha256
+               (base32
+                "0m6v1wdavw4r25jfywqchsx0v9ss1l5fr8vq9d0d8cmjnz8mqblv"))))
+    (build-system gnu-build-system)
+    (arguments
+     `(#:configure-flags
+       `(,(string-append "--prefix="
+                         (assoc-ref %outputs "out"))
+         ,(string-append "--with-cupsfilterdir="
+                         (assoc-ref %outputs "out") "/lib/cups/filter")
+         ,(string-append "--with-cupsppddir="
+                         (assoc-ref %outputs "out") "/share/ppd"))))
+    (inputs `(("cups" ,cups-minimal)))
+    (synopsis "ESC/P-R printer driver")
+    (description "ESC/P-R driver and PPDs supporting a multitude of Epson printers.")
+    (home-page "http://download.ebz.epson.net/dsc/search/01/search")
+    (license license:gpl2+)))
-- 
2.14.3

bug#29096: [PATCH] gnu: Add Epson escpr printer driver.

[Ludovic Courtès]

[-- Attachment #1: Type: text/plain, Size: 506 bytes --]

Diego Nicola Barbato <dnbarbato@posteo.de> skribis:

>>From 5d6449cc3cfc4154fff24abcdd54c05b44b9e471 Mon Sep 17 00:00:00 2001
> From: Diego Nicola Barbato <dnbarbato@posteo.de>
> Date: Wed, 1 Nov 2017 02:48:14 +0100
> Subject: gnu: Add Epson escpr printer driver.
>
> * gnu/packages/cups.scm (escpr): New variable.

Pushed with the minor changes below (notice that the license is ‘gpl2+’
because headers in source code explicitly say “or any later version”.)

Thank you!

Ludo’.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 1226 bytes --]

diff --git a/gnu/packages/cups.scm b/gnu/packages/cups.scm
index 54a93fe49..bbf2699f0 100644
--- a/gnu/packages/cups.scm
+++ b/gnu/packages/cups.scm
@@ -604,7 +604,7 @@ and more.  See @file{README} for details.")
   (package
     (name "escpr")
     (version "1.6.17")
-    ;; This currently works.  But it will break as soon as a newer
+    ;; XXX: This currently works.  But it will break as soon as a newer
     ;; version is available since the URLs for older versions are not
     ;; preserved.  An alternative source will be added as soon as
     ;; available.
@@ -628,6 +628,10 @@ and more.  See @file{README} for details.")
                          (assoc-ref %outputs "out") "/share/ppd"))))
     (inputs `(("cups" ,cups-minimal)))
     (synopsis "ESC/P-R printer driver")
-    (description "ESC/P-R driver and PPDs supporting a multitude of Epson printers.")
+    (description
+     "This package provides a filter for the Common UNIX Printing
+System (CUPS).  It offers high-quality printing with Seiko Epson color ink jet
+printers.  It can only be used with printers that support the Epson ESC/P-R
+language.")
     (home-page "http://download.ebz.epson.net/dsc/search/01/search")
     (license license:gpl2+)))

Re: [bug#29096] [PATCH] gnu: Add Epson escpr printer driver.

[Diego Nicola Barbato]

I sent a copy of this to guix-devel@gnu.org because the bug has already
been closed.

Danny Milosavljevic <dannym@scratchpost.org> writes:

> On Wed, 01 Nov 2017 03:20:04 +0100
> Diego Nicola Barbato <dnbarbato@posteo.de> wrote:
>
>> This patch adds the Epson ESC/P-R printer driver.
>
> Nice! Could you also add the escpr to the documentation in doc/guix.texi
> (in a new patch) ?
>
> Maybe extend the documentation from
>
> --------------------------------------------------------------------------
> Suppose you want to enable the Web interface of CUPS and also add
> support for HP printers @i{via} the @code{hplip} package.  You can do
> that directly, like this (you need to use the @code{(gnu packages cups)}
> module):
>
> @example
> (service cups-service-type
>          (cups-configuration
>            (web-interface? #t)
>            (extensions
>              (list cups-filters hplip))))
> @end example
> --------------------------------------------------------------------------
>
> to
>
> --------------------------------------------------------------------------
> Suppose you want to enable the Web interface of CUPS, add support for Epson printers $i{via}
> the @code{escpr} and also add support for HP printers @i{via} the @code{hplip} package.  You can do
> that directly, like this (you need to use the @code{(gnu packages cups)}
> module):
>
> @example
> (service cups-service-type
>          (cups-configuration
>            (web-interface? #t)
>            (extensions
>              (list cups-filters escpr hplip))))
> @end example
> --------------------------------------------------------------------------
>
> (if that's how it's used).

Yes this is how it is used.  I additionally installed it into my user
profile so as to have easier access to the ppd files.

> I think otherwise it's not really discoverable for the regular user how to
> use this (installing the package into the user profile would do nothing,
> right?).

I agree that it is hard to discover.  Is it OK if I simply apply your
proposed extension to the documentation?

> I wonder whether we should extend the default cups-configuration
> to list both escpr and hplib.  But that's for later...

Thanks.

Diego

Re: [bug#29096] [PATCH] gnu: Add Epson escpr printer driver.

[Danny Milosavljevic]

On Fri, 26 Jan 2018 23:19:17 +0100
Diego Nicola Barbato <dnbarbato@posteo.de> wrote:

> I agree that it is hard to discover.  Is it OK if I simply apply your
> proposed extension to the documentation?

Yes.