From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37507) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eQJjd-0005q4-U7 for guix-patches@gnu.org; Sat, 16 Dec 2017 16:11:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eQJja-0006lY-M7 for guix-patches@gnu.org; Sat, 16 Dec 2017 16:11:05 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:57297) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eQJja-0006lK-IF for guix-patches@gnu.org; Sat, 16 Dec 2017 16:11:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eQJja-0003PQ-9Q for guix-patches@gnu.org; Sat, 16 Dec 2017 16:11:02 -0500 Subject: [bug#29740] [PATCH] gnu: system: vm: Use loose cache for 9p file system. Resent-Message-ID: References: <20171216192018.19417-1-mail@cbaines.net> <20171216202514.GA21263@jasmine.lan> From: Christopher Baines In-reply-to: <20171216202514.GA21263@jasmine.lan> Date: Sat, 16 Dec 2017 21:10:12 +0000 Message-ID: <87shca5qh7.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Leo Famulari Cc: 29740@debbugs.gnu.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Leo Famulari writes: > On Sat, Dec 16, 2017 at 07:20:18PM +0000, Christopher Baines wrote: >> This improves the performance of the shared store for operations involvi= ng >> lots of files, e.g. searching through the store. >>=20 >> * gnu/system/vm.scm (mapping->file-system): Add cache=3Dloose to options. > > Okay! > >> diff --git a/gnu/system/vm.scm b/gnu/system/vm.scm >> index 6102d465b..c1305d3f9 100644 >> --- a/gnu/system/vm.scm >> +++ b/gnu/system/vm.scm >> @@ -554,7 +554,7 @@ of the GNU system as described by OS." >> (device (file-system->mount-tag source)) >> (type "9p") >> (flags (if writable? '() '(read-only))) >> - (options (string-append "trans=3Dvirtio")) >> + (options "trans=3Dvirtio,cache=3Dloose") > > Was that string-append unnecessary in this context? I think so. It has always been like this I think, and I haven't had any problems with this change. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAlo1i7RfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE 9Xemaw/+Pt6ijyD/UpfF3cB5qQYQiZEdnYv51xWE4Xw8mhb3dTs1IdDXdW0SY73J YzWNf7vtbOzvp7EIyQqGjPAW1mBsps+NRoS0pNEtcHagYMHb/szZo4c9OXFpD/TT 1M3gXq0z+n8IIVxwEHmxRF5+ALupnWsGDgDh7CVfvekdctBKNYrP6XwZShc3Taye izvG5xjvPOiRrAtsuZ7mtAZ1INy/MIJGft8zCFK1jvCIgee+xfhwhYQxogRNIsTw 0VQk0WsZ149MdPrKnhIXwwdkaqAjXWZkau/gyQnGk/sbH9CiFOsZymtgrTtPbKao mkEq9lknQUXn2p3nN+/rLfQSk85wLwacN1DC4Rlw8QpEvK6uTM2XaP2XOoaEq8YP 6HxqrvJFxKQdIC0PKtURnKIINGlKIvlvdM84XeuFaKdC9cnIRDe6m6vmjIuLCDRf IYDb6T+wIpKWRMLktcy6ET4M8KC4n1gWUjGAADbrJ3Ot3aYtcLlmXYnhyR+kso7W LxOaT50JqKFaImoHRW+rjSuZYlqx/UtlykAepizYe8RXpA66izfULI932aSNU3Kz AJ9aF11JnwAy+81gSvY7Lcg8onZTvRrMyHHo7drMAGgwxET4MHXesqNqXvvIUiEZ Ahu7DWgetUlU4CWStjXysNy2isd6oLQHinWpyKWhk+JYCaw/tgU= =EcfB -----END PGP SIGNATURE----- --=-=-=--