From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53580) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f1euw-0002BT-Bk for guix-patches@gnu.org; Thu, 29 Mar 2018 17:17:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f1eus-0007n4-32 for guix-patches@gnu.org; Thu, 29 Mar 2018 17:17:06 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:51202) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1f1eur-0007mu-V2 for guix-patches@gnu.org; Thu, 29 Mar 2018 17:17:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1f1eur-0006nT-LP for guix-patches@gnu.org; Thu, 29 Mar 2018 17:17:01 -0400 Subject: [bug#30948] [PATCH core-updates] guix: Reap finished child processes in build containers. Resent-Message-ID: References: <87muyvulwt.fsf@zancanaro.id.au> <87bmf6ve6u.fsf@gnu.org> From: Carlo Zancanaro In-reply-to: <87bmf6ve6u.fsf@gnu.org> Date: Fri, 30 Mar 2018 08:15:51 +1100 Message-ID: <87sh8id1mg.fsf@zancanaro.id.au> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 30948@debbugs.gnu.org --=-=-= Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Hey Ludo, On Thu, Mar 29 2018, Ludovic Court=C3=A8s wrote: > I would rather install the handler as a phase in=20 > gnu-build-system: this leaves =E2=80=98build-expression->derivation=E2=80= =99=20 > generic, and also gives us more flexibility (e.g., we can=20 > disable that phase without doing a full rebuild if needed.) See=20 > the patch below. > > WDYT? What do you mean by "generic"? From what I can understand it's one=20 of pid 1's responsiblities to reap child processes, so I would=20 expect this to be set up for every builder, before the builder is=20 run. Given it's not specific to the gnu-build-system, I don't=20 think it really fits there. > On my first attempt with: > > ./pre-inst-env guix build -e '(@@ (gnu packages commencement)=20 > findutils-boot0)' > > quickly failed: > > ... > > This is why =E2=80=98install-SIGCHLD-handler=E2=80=99 in the patch does n= othing=20 > on Guile <=3D 2.0.9. From=20what I understand, Guix depends on Guile 2.0.13 or later, so=20 I didn't think it needed to work with 2.0.9. From my quick check,=20 though, our bootstrap binaries are Guile 2.0.9? I can see how that=20 might cause a problem. In what sense does Guix require 2.0.13 (as=20 the manual claims) rather than 2.0.9? > Now, we=E2=80=99d need to test it for real with Guile 2.2. I suppose=20 > one way to > test without rebuilding it all would be to add this phase=20 > explicitly in > a package and try building it with --rounds=3D10 or something.=20 > Would you > like to try that? Yeah, I'll give it a go. Carlo --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEE1lpncq7JnOkt+LaeqdyPv9awIbwFAlq9V4gACgkQqdyPv9aw IbwfFA/6A+eIjcEhtb6obaSPl1hhiZj/bPIftEpE5m/DS0AHqxsAfwejLA6I/av6 jJdswbSER/nQanDO5u685G0pvQLmJL5NlFCrjC4Ji/vi0FlTtVOOI8xaUsQFrXrb eu+HhWg891VvI1hKSfrQm8ZOYzi+SyayCatontP4M4rUFbzY4UQFJZNf8IPtUAY/ N7YVv3UJ2nGGGOMU89u52idSpVxBRBesdUyszvLTW4yLKXM7wjpDP4jq1W+MJ8j+ kXEn7iNNG8L1jOTgCNPOrD0j+pnlyh4hCstaDx8AcJsbJO7cUCM3/t86Nogo27R2 nY8M+ayYUZ3mpoU4PfTDQZ4dVUoxFPqJ+mAqZ3NtYLrRZLlQQots+qLWTSIsUqoz MI8+yaMbQej7sEGrU6pJUmwKggEpMbKdHrTsUPXAXHupBylyoXnboIzCh0aJ9kAR 4u0djoW/eAJo6Z7AuxCuO023z0mTqeAgI5dkPUx4C0S8Zl3csaFP/rO9SzFvehSy +iWgD8BCJTZEMtgX+WUWyO37FyvvCCvOtrcLgizBJ3m2OdYZ/U1kbS3HqFaxgtvp pEuwPWNnYNk5mM09dl/l7aV9TCbJRuryZV5Ued5pP9P9JCRcHIaz756AW98uZs3C b9r2Bc6xVhkWiEv0SXv42HFCUJcfHhOS2e/BJO6F4Q/xufEnj8Y= =3nBj -----END PGP SIGNATURE----- --=-=-=--