From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49325) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f8CFG-0001Hh-6B for guix-patches@gnu.org; Mon, 16 Apr 2018 18:05:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f8CFC-0006dW-QB for guix-patches@gnu.org; Mon, 16 Apr 2018 18:05:06 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:48444) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1f8CFC-0006dJ-M6 for guix-patches@gnu.org; Mon, 16 Apr 2018 18:05:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1f8CFC-0008OK-Dz for guix-patches@gnu.org; Mon, 16 Apr 2018 18:05:02 -0400 Subject: [bug#31121] [PATCH 3/3] gnu: Add osc. Resent-Message-ID: From: Marius Bakke In-Reply-To: <20180410092935.5915-2-sleep_walker@gnu.org> References: <20180410092935.5915-1-sleep_walker@gnu.org> <20180410092935.5915-2-sleep_walker@gnu.org> Date: Tue, 17 Apr 2018 00:04:28 +0200 Message-ID: <87sh7udd03.fsf@fastmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: =?UTF-8?Q?Tom=C3=A1=C5=A1_?= =?UTF-8?Q?=C4=8Cech?= , 31121@debbugs.gnu.org --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Tom=C3=A1=C5=A1 =C4=8Cech writes: > * gnu/packages/python.scm (osc): New variable. Woo, awesome! :-) I wonder if this could go in 'build-tools.scm' since it's not really a generic Python library in the traditional sense. Or maybe we should add an 'obs' module? > +(define-public osc > + (package > + (name "osc") > + (version "0.162.1") > + (source > + (origin > + (method url-fetch) > + (uri (string-append "https://github.com/openSUSE/" name "/archive= /" version ".tar.gz")) This line is too long (I believe guix lint will agree). > + (file-name (string-append name "-" version ".tar.gz")) > + (sha256 > + (base32 > + "0b4kpm96ns4smqyfjysbk2p78d36x44xprpna8zz85q1y5xn57aj")))) > + (build-system python-build-system) > + (arguments > + `(#:python ,python-2 > + #:phases > + (modify-phases %standard-phases > + (add-after 'install 'fix-filename-and-remove-unused > + (lambda* (#:key outputs #:allow-other-keys) > + (let ((bin (string-append (assoc-ref outputs "out") "/bin/"= ))) > + ;; osc tool is renamed in spec file, not setup.py, let's = do > + ;; that too Nit-pick: Please use capitalisation and punctuation in comments. > + (rename-file > + (string-append bin "osc-wrapper.py") > + (string-append bin "osc")) > + ;; unused and broken script ... and here. > + (delete-file (string-append bin "osc_hotshot.py")) > + #t)))))) > + (inputs > + `(("python2-urlgrabber" ,python2-urlgrabber) > + ("python2-pycurl" ,python2-pycurl))) > + (propagated-inputs > + `(("python2-m2crypto" ,python2-m2crypto))) Why is m2crypto propagated, but the others are not? Does the automatic wrapper not take care of it? > + (home-page "https://github.com/openSUSE/osc") > + (synopsis "Open Build Service command line tool") > + (description "Command line interface to Open Build Service. It allo= ws you Again, full sentences please :-) "@command{osc} is a command line interface= ...". > +to checkout, commit, perform reviews etc. Vast majority of the OBS ^^^ s/Vast/The vast/ > +functionality is available via commands and the rest can be reached via = direct > +API calls.") > + (license license:gpl2+))) > --=20 > 2.17.0 Can you send updated patches? --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAlrVHewACgkQoqBt8qM6 VPoYQQgAo1xMmhTXw8EiEYlxfNoyWHmjB4qZ5BFPGCwCGwWkXL/ZW+dlPSXhjw6o hvkOMbY7HTDbperLa+t8hzSr9wfjUAE/p9vOvtEXrmeHg85uTgWKx1f0Qf4EVcTk qo7UxP5Y+Vyz1WJi0pWqhGI1ybk8HxKvV1iwdJhA0WrmC3ffvrgmjkfFWdwHWwOG Y+udtni7vtAaVRhUst9YB8yklxdx8cU1akKgZYt1MTDUybpZ2kzwavA13A+A5H/C GNDeeZIHUCUBT5lABQ+r+0jvYIR1yWF41p7fMsk5X7Hdws4LChcYctRAjyQ+ltSV rFfwGfei3g1pDs2/u2OvZz17qbE9hw== =rkc3 -----END PGP SIGNATURE----- --=-=-=--