From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38572)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1fMBRz-0003y5-KX
	for guix-patches@gnu.org; Fri, 25 May 2018 08:04:09 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1fMBRy-0006we-T1
	for guix-patches@gnu.org; Fri, 25 May 2018 08:04:03 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:39659)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1fMBRy-0006wX-Pc
	for guix-patches@gnu.org; Fri, 25 May 2018 08:04:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1fMBRy-0000ey-3J
	for guix-patches@gnu.org; Fri, 25 May 2018 08:04:02 -0400
Subject: [bug#31259] [PATCH] Add gnuradio
Resent-Message-ID: <handler.31259.B31259.15272498402527@debbugs.gnu.org>
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
References: <cuczi1rbmkc.fsf@posteo.net>
	<20180425133627.35995620@scratchpost.org>
Date: Fri, 25 May 2018 14:03:46 +0200
In-Reply-To: <20180425133627.35995620@scratchpost.org> (Danny Milosavljevic's
	message of "Wed, 25 Apr 2018 13:36:27 +0200")
Message-ID: <87sh6g2b8d.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Charlie Ritter <chewzerita@posteo.net>
Cc: 31259@debbugs.gnu.org

Hello Charlie,

Did you have a chance to look at implementing Danny=E2=80=99s suggestions?

Looks like we=E2=80=99re almost there so it would be sad to let the patch
bitrot!

Thanks,
Ludo=E2=80=99.

Danny Milosavljevic <dannym@scratchpost.org> skribis:

> Hi!
>
> Thanks for the patch.
>
> I have the following suggestions:
>
> * Please unbundle volk.
> * Please build the documentation (that needs doxygen, ghostscript and tex=
live-tiny).  After that, remove docs/doxygen/html/_formulas.log because it =
contains timestamps.
> * Please add dependency to alsa-lib.
> * Please add dependency to libusb.
> * Why not fftwf?
> * We should investigate whether grc actually needs the inputs to be propa=
gated (later).
> * Please add dependency to cppunit.
> * Please add dependency to orc.
> * Swig probably is not needed at runtime - isn't a native-input enough?