From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51123) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fuYqL-0001bu-Gk for guix-patches@gnu.org; Tue, 28 Aug 2018 03:55:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fuYiR-0004mF-IK for guix-patches@gnu.org; Tue, 28 Aug 2018 03:47:11 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:58004) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fuYiM-0004k7-A5 for guix-patches@gnu.org; Tue, 28 Aug 2018 03:47:05 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fuYiM-000622-1d for guix-patches@gnu.org; Tue, 28 Aug 2018 03:47:02 -0400 Subject: bug#32346: [PATCH 1/6] services: tor: Add a system test. Resent-To: guix-patches@gnu.org Resent-Message-ID: From: Chris Marusich References: <20180802064520.20273-1-cmmarusich@gmail.com> <20180802065159.20413-1-cmmarusich@gmail.com> <874lfoerh2.fsf@gnu.org> Date: Tue, 28 Aug 2018 00:46:05 -0700 In-Reply-To: <874lfoerh2.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Mon, 20 Aug 2018 22:02:49 +0200") Message-ID: <87sh2zaq82.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 32346-done@debbugs.gnu.org --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi Ludo, I've incorporated your feedback and committed this patch series as 3bcb305b98e02f6c9d98e7325813fc00f18f0e6c. Details follow. ludo@gnu.org (Ludovic Court=C3=A8s) writes: > Chris Marusich skribis: > > > [...] > >> + ;; Allow TOR to write its PID file. > > Nitpick: I think the maintainers no longer consider the name an acronym > and write it as =E2=80=9CTor=E2=80=9D, not =E2=80=9CTOR=E2=80=9D. This is good to know. In each patch that uses the incorrect name "TOR", I've changed it to use the correct name "Tor". >> +(define* (wait-for-unix-socket path marionette > > Super nitpick: s/path/file/ or s/path/file-name/, as per GNU > convention (where =E2=80=9Cpath=E2=80=9D means =E2=80=9Csearch path=E2=80= =9D.) I've updated this to follow the convention. >> +@deftp {Data Type} tor-configuration >> +@table @asis >> +@item @code{tor} (default: @code{tor}) >> +The package that provides the TOR daemon. This package is expected >> to provide >> +the daemon at @file{bin/tor} relative to its output directory. The def= ault >> +package is the @uref{https://www.torproject.org, TOR Project's} >> +implementation. >> +@item @code{config-file} (default: @code{(plain-file "empty" "")}) > > You could skip a line between between each @item for clarity. Good idea. I've done this, too. > Thank you for this nice patch series! Thank you for the thoughtful review! I appreciate your attention to detail. If you hadn't told me, I wouldn't have known about some of these things, such as the GNU convention to use "file" or "file-name" instead of "path" when speaking about UNIX domain sockets. I'll remember these things going forward. And with that, I will now close this patch! =2D-=20 Chris --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEy/WXVcvn5+/vGD+x3UCaFdgiRp0FAluE/b4ACgkQ3UCaFdgi Rp0myA/7BgAGGSU8jZJnOzkoF+lzAXE4fjSZNZPQDRLCZzxO8bPaaNU/ZVsyczs/ 3CCkmJZhTLWqd9N72KaXLMTbdK9couxT+1vdcPMLLgNnWlz7S/f83YGZsuEjG9Do /ePxEXN5Nh3qZcPhmOm2o6X7xsbo5gyPKmQMW+atOCiAHkMl2kTEOEUfGJ0ZZzOf q9J0I7Dnbbkv/y285r1eU1VIplTruMsp+KmpreM6cRgbItc+yDR1QXoQwrlG3Arp AhTXL/HC7RTvyDrJSOYOdwjb2VJFqjpXLgWjjFSSONxqmqQMK7O0qBTIhqIZ9Gw2 oYNPbXNXWavFCJma24bc0rRBYw24EYxmbHdvGqu69/uo1JrZsFdbN1zxgdlYR/hm ++VjeabNZDaJS7/ZlNA4sc6wZqJz9fR0EPHxGJ4f22Qag0TlCZfCZ2gzTtZJYRD6 Q1OCGLz7J64H0z9/c7zuYOo7Tu4cGfCDTJq6qt9lkk0Qjlk6wWwZ38R4S3VoQdZH uqmMnEEiObv/MvLXSnRkYBGyvwZx0bdqY67ADskySLJaalBhJ2m625Z0jmBtbJ8N 6d27gROWPpdyD+Xg2mokbWq8zb/Geu3cVJntt1MKX8eqSBPtEciugpxAmsJegWM0 bcQPQ+VN1PAyF0v8wCbZR6TC+kAONEYZktv1d+XkzZ3hNHbQbwg= =CoK0 -----END PGP SIGNATURE----- --=-=-=--