From: "Clément Lassieur" <clement@lassieur.org>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 32879@debbugs.gnu.org
Subject: [bug#32879] [PATCH] database: Add builds only if one of their outputs is new.
Date: Mon, 01 Oct 2018 11:09:59 +0200 [thread overview]
Message-ID: <87sh1qxcbc.fsf@lassieur.org> (raw)
In-Reply-To: <87k1n2pvjx.fsf@lassieur.org>
Clément Lassieur <clement@lassieur.org> writes:
> Ludovic Courtès <ludo@gnu.org> writes:
>
>> Hello Clément,
>>
>> Clément Lassieur <clement@lassieur.org> skribis:
>>
>>> * Makefile.am (dist_sql_DATA): Add 'src/sql/upgrade-4.sql'.
>>> * src/cuirass/database.scm (db-add-output): New procedure.
>>> (db-add-build): Call DB-ADD-OUTPUT, rollback the transaction and return #f if
>>> DB-ADD-OUTPUT returned an empty list.
>>> * src/schema.sql (Outputs): Set 'path' as primary key, instead of 'derivation,
>>> name'.
>>> * src/sql/upgrade-4.sql: New file with SQL queries to upgrade the database.
>>> * tests/database.scm (make-dummy-build): Use the #:OUTPUTS key. Get default
>>> OUTPUTS to depend on DRV.
>>> ("db-add-build-with-fixed-output"): New test.
>>
>> What’s the rationale? I suppose having a simpler primary key for
>> ‘Outputs’ might help performance?
>
> There is a slight performance and db size gain but the primary reason is
> to have a better idea of Cuirass' load when looking at the pending
> builds. There will be less (no?) 'fake' builds. The idea is that all
> builds should be real builds.
Also, it would allow to be notified when someone pushes on master a
commit that triggers too many builds.
next prev parent reply other threads:[~2018-10-01 9:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-29 20:35 [bug#32879] [PATCH] database: Add builds only if one of their outputs is new Clément Lassieur
2018-09-30 19:34 ` Ludovic Courtès
2018-09-30 20:41 ` Clément Lassieur
2018-10-01 9:09 ` Clément Lassieur [this message]
2018-10-02 9:08 ` Ludovic Courtès
2018-10-02 11:26 ` bug#32879: " Clément Lassieur
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sh1qxcbc.fsf@lassieur.org \
--to=clement@lassieur.org \
--cc=32879@debbugs.gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.