From mboxrd@z Thu Jan 1 00:00:00 1970 From: Meiyo Peng Subject: Re: Package for LXQt. Help wanted. Date: Fri, 26 Oct 2018 23:11:25 +0800 Message-ID: <87sh0soi8y.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:40566) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gG3lz-0001Tw-Ms for guix-devel@gnu.org; Fri, 26 Oct 2018 11:11:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gG3lu-0004uU-O6 for guix-devel@gnu.org; Fri, 26 Oct 2018 11:11:39 -0400 Received: from mail-pf1-x433.google.com ([2607:f8b0:4864:20::433]:35324) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gG3lt-0004sG-Gu for guix-devel@gnu.org; Fri, 26 Oct 2018 11:11:34 -0400 Received: by mail-pf1-x433.google.com with SMTP id l17-v6so714891pff.2 for ; Fri, 26 Oct 2018 08:11:31 -0700 (PDT) List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: iyzsong@member.fsf.org Cc: guix-devel@gnu.org Hello Song, > Hello, thank you again, I have push them! Thank you. > - Add comments about the missing translations (disable the > PULL_TANSLATIONS), which are in the lxqt-l10n git repository. I think > we can prefetch it as a 'origin', add it to the input of the > application, or add a 'lxqt-l10n' package. I didn't add lxqt-l10n because it is stated as deprecated on it's home page. > - Correct some licenses, eg: obconf-qt, qps are under GPL2+. Sorry about this. I should have been more careful. > And a "lxqt-build-tools: Dedifen LXQT_*_DIR variables" patch is > unapplied: > > (build-system cmake-build-system) > (arguments > - `(#:tests? #f)) ; no tests > + `(#:tests? #f ;; no tests > + #:configure-flags > + `("-DLXQT_DATA_DIR=/run/current-system/profile/share" > + "-DLXQT_ETC_XDG_DIR=/run/current-system/profile/etc/xdg"))) > > What are thoses variables used for? If I install the 'lxqt' package > into my user profile, should I set them to the directories under my > profile ($HOME/.guix-profile/share and $HOME/.guix-profile/etc/xdg)? These variables are used by all LXQt packages during build time. But there is no big issue if they are not defined here, I guess it is because XDG_*_DIRS environment variables are set correctly during runtime. They default to directories within /gnu/store/*-lxqt-build-tools-*/ like this: "/gnu/store/86wy8q4yplhalf3yvmzv673naarxn3na-lxqt-build-tools-0.5.0/share" I defined these variables here to serve an aesthetic purpose, so that the "Technical Info" tab within lxqt-about can show the values defined above rather than directories like this: "/gnu/store/86wy8q4yplhalf3yvmzv673naarxn3na-lxqt-build-tools-0.5.0/share". -- Meiyo Peng