From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:55651) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gri59-00046E-Pm for guix-patches@gnu.org; Thu, 07 Feb 2019 06:43:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gri58-0003T2-Qp for guix-patches@gnu.org; Thu, 07 Feb 2019 06:43:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:37335) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gri58-0003So-MD for guix-patches@gnu.org; Thu, 07 Feb 2019 06:43:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gri58-0002ln-FB for guix-patches@gnu.org; Thu, 07 Feb 2019 06:43:02 -0500 Subject: [bug#34365] [PATCH] gnu: Add python-daemon. Resent-Message-ID: From: Vagrant Cascadian In-Reply-To: <874l9gexmz.fsf@elephly.net> References: <87va1w6iki.fsf@ponder> <874l9gexmz.fsf@elephly.net> Date: Thu, 07 Feb 2019 03:42:29 -0800 Message-ID: <87sgwz7rkq.fsf@ponder> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ricardo Wurmus Cc: 34365@debbugs.gnu.org --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 2019-02-07, Ricardo Wurmus wrote: >> * gnu/packages/python-xyz.scm (python-daemon): New variable. > > Thanks for the patch! Thanks for the lightning fast review! >> + (add-before 'check 'disable-tests >> + (lambda _ >> + ;; FIXME: Determine why test fails >> + (substitute* "test/test_daemon.py" >> + (("test_detaches_process_context") >> + "skip_test_detaches_process_context"))))))) > > Before pushing this I=E2=80=99ll add a final #T to this phase. (In the p= ast #F > would indicate failure, but that=E2=80=99s on longer the case. =E2=80=9C= substitute*=E2=80=9D > annoyingly returns an unspecified value.) My eyes still have trouble identifying where exactly this would go... and #T/#F vs. #t/#f has me a bit confused for good measure! Obviously, it'd be better to fix the test, or at least understand why it fails... >> + (propagated-inputs >> + `(("python-docutils" ,python-docutils) >> + ("python-lockfile" ,python-lockfile) >> + ("python-setuptools" ,python-setuptools))) >> + (native-inputs >> + `(("python-unittest2" ,python-unittest2) >> + ("python-testtools" ,python-testtools) >> + ("python-testscenarios" ,python-testscenarios) >> + ("python-mock" ,python-mock) >> + ("python-docutils" ,python-docutils))) > > Docutils is both among native inputs as well as regular inputs. Is this > intended? I *think* it only needs to be in native-inputs; I think propagated outputs was generated by the importer... and now that my attention is drawn to it, I'm dubious of python-setuptools needing to be in propagated-inputs as well. I can update it and check again later... >> + (license (list license:asl2.0 license:gpl3+)))) > > What does this list mean? I guess it's best practice in Guix to make a comment when multiple licenses are listed? Apparently only setup.py is gpl3+, everything else is apache 2.0 licensed. That was my quick look at the code itself, and basically confirmed by: https://sources.debian.org/src/python-daemon/2.2.3-1/debian/copyright/ live well, vagrant --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQRlgHNhO/zFx+LkXUXcUY/If5cWqgUCXFwZpgAKCRDcUY/If5cW qp5PAP0TOhbEY1XyFy7oOSOmRpMXySdGkU5Ul7ghc3WqlqhaDAD8CwxsFWsvlxT7 lw67oPHzsEtb0EtKN2DRml+RvC75iQE= =pkAH -----END PGP SIGNATURE----- --=-=-=--