From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:41845) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h1E7j-0003l2-T8 for guix-patches@gnu.org; Tue, 05 Mar 2019 12:45:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h1E7j-0003wp-0x for guix-patches@gnu.org; Tue, 05 Mar 2019 12:45:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:48102) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1h1E7i-0003wQ-RP for guix-patches@gnu.org; Tue, 05 Mar 2019 12:45:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1h1E7i-00031P-Gt for guix-patches@gnu.org; Tue, 05 Mar 2019 12:45:02 -0500 Subject: [bug#34758] Acknowledgement ([PATCH 1/4] gnu: Add libmirage.) Resent-Message-ID: References: <20190305172620.20118-1-mail@ambrevar.xyz> From: Pierre Neidhardt In-reply-to: Date: Tue, 05 Mar 2019 18:44:25 +0100 Message-ID: <87sgw1fc7a.fsf@ambrevar.xyz> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: 34758@debbugs.gnu.org --=-=-= Content-Type: text/plain libmirage, cdemu-daemon and cdemu-client seems to be fine. The VHBA kernel module is not package properly and this a blocker for cdemu-daemon. 1. This raises the more general issue of building kernel modules on Guix. For the record, here is the VHBA makefile: --8<---------------cut here---------------start------------->8--- VHBA_VERSION := 20170610 KERNELRELEASE ?= $(shell uname -r) KDIR ?= /lib/modules/$(KERNELRELEASE)/build PWD ?= $(shell pwd) obj-m := vhba.o ccflags-y := -DVHBA_VERSION=\"$(VHBA_VERSION)\" -Werror default: modules install: modules_install modules modules_install clean: $(MAKE) -C $(KDIR) M=$(PWD) $@ --8<---------------cut here---------------end--------------->8--- As you can see, it relies on the Makefile (and probably a bunch of other files) in /lib/modules/$(KERNELRELEASE)/build. In our linux-libre package, "build" is a broken symlink, e.g. to /tmp/guix-build-linux-libre-4.20.12.../linux-4.20.12. Shouldn't we include this folder in the linux-libre package? Without it, I can't see how to build kernel modules. Once we have this, we will be able to build vhba-module. 2. Next question: how do we load this module? In `operating-system' we have `initrd-modules', but in this case vhba is probably not needed in the initrd. What we really want, I think, is a union of kernel modules in say /run/booted-system/kernel/lib/modules/4.20.7/ Makes sense? Thoughts? -- Pierre Neidhardt https://ambrevar.xyz/ --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEUPM+LlsMPZAEJKvom9z0l6S7zH8FAlx+tXkACgkQm9z0l6S7 zH9YrAf/RfjyKdKkKid+FpnR9StQ8nHGAbJzZmXnJR1rvGi1cepHnDneoZR8bZUf CbOazqTMQ5jP6pWPNvomxBZPjfnVctHVvLWlsdYRchEAGMT5enfexGAzSU1ZmgtT HK7lzbTupIqkFVcFlO6FgLvJgQxRTI4YtevlK6Jhvdk560qaVwsxkCJ3z/rg5RET Au9ke6V3Ql0Vo3pSy4GuVya9Do/F0fotxdrMA/q+bZNl1wg+BK8kyhj3C1O1rWQD z6vfSeGGzChu7UuezpwtQDamEzCPc0i0c56QHOT2V3IzyiT6VrXISoTuMlPUqFZj Cfe+T9D5bgBaBib/DM/EkkDhJgKBRg== =dFYW -----END PGP SIGNATURE----- --=-=-=--