From mboxrd@z Thu Jan 1 00:00:00 1970 From: Caleb Ristvedt Subject: Re: 02/09: guix: store: Make register-items transactional, register drv outputs Date: Mon, 01 Apr 2019 12:53:36 -0500 Message-ID: <87sgv11ujj.fsf@cune.org> References: <20190204192241.15758.66035@vcs0.savannah.gnu.org> <20190204192243.D1BD820B84@vcs0.savannah.gnu.org> <87wom8pqbi.fsf@gnu.org> <87o97gcc3w.fsf@cune.org> <877edcjgbj.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([209.51.188.92]:33955) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hB17t-0005am-9L for guix-devel@gnu.org; Mon, 01 Apr 2019 13:53:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hB17s-0007b8-6b for guix-devel@gnu.org; Mon, 01 Apr 2019 13:53:41 -0400 Received: from mail-it1-x132.google.com ([2607:f8b0:4864:20::132]:53308) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hB17r-0007ah-PY for guix-devel@gnu.org; Mon, 01 Apr 2019 13:53:40 -0400 Received: by mail-it1-x132.google.com with SMTP id y204so506407itf.3 for ; Mon, 01 Apr 2019 10:53:39 -0700 (PDT) In-Reply-To: <877edcjgbj.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Wed, 06 Mar 2019 14:14:08 +0100") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: ludo@gnu.org Cc: guix-devel@gnu.org > A problem is that we should not pull in these two modules here, because > they are conceptually at a higher level (they have to do with talking to > a separate daemon process.) > > So perhaps a first step would be to re-arrange things, probably along > these lines: > > =E2=80=A2 Move the .drv parsing code and the record type f= rom > (guix derivations) to, say, (guix store derivations). > > =E2=80=A2 Re-export all these bindings from (guix derivations). > > =E2=80=A2 Move =E2=80=98store-path?=E2=80=99, =E2=80=98derivation-path?= =E2=80=99 & co. (everything below line > 1745 in guix/store.scm) to, say, (guix store files). Re-export > appropriately so the API remains unchanged. > > At this point, (guix store =E2=80=A6) modules won=E2=80=99t have to use (= guix store) and > (guix derivations) at all. > > How does that sound? As we found out on IRC yesterday, https://bugs.gnu.org/15602 is causing this to fail. If I understand correctly, the workaround involves trying to make sure that modules that use (guix memoization) are compiled before (guix memoization) is (and it turns out that once that's solved the same issue occurs with (guix config)). Considering that the module-import-compiled builders just do a depth-first-search for scheme source files ordered alphabetically, that's a bit tricky. I ended up making a dummy module, (gnu build dummy), that does nothing but use (guix config) and (guix memoization), and the tests now pass. Does a better workaround exist? Could we pass an ordered list of files to the builder somehow instead of just a directory? But then again, changing every module-import-compiled would mean rebuilding the world. Eh. Thoughts? Oh, also, should I just copy all the copyright lines from the old modules to the new ones? - reepca