From mboxrd@z Thu Jan 1 00:00:00 1970 From: Brett Gilio Subject: bug#38613: Disabling bytecompilation on a list of files. Date: Mon, 23 Dec 2019 18:31:05 -0600 Message-ID: <87sglak1iu.fsf@gnu.org> References: <8736dl5ipq.fsf@posteo.net> <0b47c65b310b0a0c9e5821070d5e4a888a8c4a58.camel@student.tugraz.at> <875zifmtlq.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:470:142:3::10]:53944) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ijY7Q-0002o2-5W for bug-guix@gnu.org; Mon, 23 Dec 2019 19:32:13 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ijY7M-0005Go-GY for bug-guix@gnu.org; Mon, 23 Dec 2019 19:32:11 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:45838) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ijY7G-0005Dc-EC for bug-guix@gnu.org; Mon, 23 Dec 2019 19:32:07 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ijY7G-0000bx-9k for bug-guix@gnu.org; Mon, 23 Dec 2019 19:32:02 -0500 Sender: "Debbugs-submit" Resent-Message-ID: In-Reply-To: <875zifmtlq.fsf@gmail.com> (Maxim Cournoyer's message of "Tue, 17 Dec 2019 14:03:29 +0900") List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org Sender: "bug-Guix" To: Maxim Cournoyer Cc: Leo Prikler , 38613@debbugs.gnu.org Maxim Cournoyer writes: > Hello, > > Leo Prikler > > [...] > >> Regarding the impact, I think it should be fine if we commit this >> closely before or after #38619, since that probably forces all Elisp >> libraries to be rebuilt anyways (also CC'd Maxim to have a look at >> this). Hopefully at least the doom-theme autoloads compile correctly. >> WDYT? >> >> Leo > > IIRC, emacs{-minimal} have about ~300 non-Elisp dependents, which IMO is > OK for master (Elisp packages are very cheap to build, so I don't count > them). > > I've just verified this with the following script: > > (use-modules (gnu packages) > (guix graph) > (guix monads) > (guix packages) > (guix store) > (guix scripts graph) > (guix scripts refresh) > (gnu packages emacs) > (srfi srfi-1) > (srfi srfi-26)) > > (define (all-packages) > "Return the list of all the distro's packages." > (fold-packages (lambda (package result) > ;; Ignore deprecated packages. > (if (package-superseded package) > result > (cons package result))) > '() > #:select? (const #t))) > > (define (packages->dependents packages) > > (define (full-name package) > (string-append (package-name package) "@" > (package-version package))) > > (with-store store > (run-with-store store > (mlet %store-monad ((edges (node-back-edges > %bag-node-type > (package-closure (all-packages))))) > (let ((dependents (node-transitive-edges packages edges))) > (return (map full-name dependents))))))) > > (define (compute-results) > (let* ((dependents (packages->dependents (list emacs emacs-minimal))) > (non-emacs (remove (cut string-prefix? "emacs-" <>) dependents))) > (format #t "Emacs{-minimal} have ~d dependents, ~d of which are not pure \ > Emacs libraries: ~a~%" (length dependents) (length non-emacs) non-emacs))) > > (compute-results) > > Which outputs: > > Emacs{-minimal} have 973 dependents, 274 of which are not pure Emacs > libraries: (faust@2.5.23 cedille@1.1.1 cflow@1.6 > translate-shell@0.9.6.11 kicad@5.1.4 lepton-eda@1.9.5-20180820 > quadrapassel@3.31.3 eog-plugins@3.26.4 workrave@1.10.34 emacsy@0.4.1 > guile-gi@0.2.0 nomad@0.1.1-alpha emacsy-minimal@v0.4.1-19.f3bf0db > evisum@0.2.6 enlightenment-wayland@0.23.1 terminology@1.5.0 ephoto@1.5 > enlightenment@0.23.1 econnman@1.1 python-efl@1.23.0 lekha@0.2.1 > python2-efl@1.23.0 edi@0.6.0 rage@0.3.1 dbus-c++@0.9.0 > [...] > > HTH, > > Maxim > > > > Leo and Maxim, Do you think this feature addition to the emacs-build-system is good to be pushed, then? I think it looks quite fine but I want to double check before potentially doing something dumb. That said, we should probably also document this. -- Brett M. Gilio GNU Guix, Contributor | GNU Project, Webmaster [DFC0 C7F7 9EE6 0CA7 AE55 5E19 6722 43C4 A03F 0EEE]