From: Marius Bakke <mbakke@fastmail.com>
To: Leo Famulari <leo@famulari.name>
Cc: 40227-done@debbugs.gnu.org
Subject: [bug#40227] [PATCH] gnu: icu4c: Fix CVE-2020-10531.
Date: Wed, 25 Mar 2020 23:41:05 +0100 [thread overview]
Message-ID: <87sghwys5a.fsf@devup.no> (raw)
In-Reply-To: <20200325215427.GA29579@jasmine.lan>
[-- Attachment #1: Type: text/plain, Size: 852 bytes --]
Leo Famulari <leo@famulari.name> writes:
> On Wed, Mar 25, 2020 at 09:23:33PM +0100, Marius Bakke wrote:
>> I'm not sure if the new test case as well as this git commit header is
>> necessary. IMO it mostly adds noise to the patch. I.e. the whole file
>> could be shortened to 6 lines + your comments at the top.
>>
>> But no strong opinion, there is an argument to be made for preserving
>> upstream commits in their entirety too (I think).
>>
>> So, LGTM either way. Thank you!
>
> I commented out the changes to the test suite and pushed as
> 7d57a190f6896c04b5dad66bf4360bc48a4052ff.
What I meant was that they could be omitted entirely to shorten the
patch (less lines to comb through for reviewers), but no worries! The
important thing is that we get the security fix, thanks for watching out
for those as always. :-)
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]
prev parent reply other threads:[~2020-03-25 22:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-25 18:36 [bug#40227] [PATCH] gnu: icu4c: Fix CVE-2020-10531 Leo Famulari
2020-03-25 20:23 ` Marius Bakke
2020-03-25 21:54 ` bug#40227: " Leo Famulari
2020-03-25 22:41 ` Marius Bakke [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sghwys5a.fsf@devup.no \
--to=mbakke@fastmail.com \
--cc=40227-done@debbugs.gnu.org \
--cc=leo@famulari.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.