From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:39451)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jNYY3-0004MH-8t
 for guix-patches@gnu.org; Sun, 12 Apr 2020 05:05:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jNYY2-0002oz-AX
 for guix-patches@gnu.org; Sun, 12 Apr 2020 05:05:03 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:45806)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1jNYY2-0002op-7S
 for guix-patches@gnu.org; Sun, 12 Apr 2020 05:05:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jNYY2-0008JY-3J
 for guix-patches@gnu.org; Sun, 12 Apr 2020 05:05:02 -0400
Subject: bug#40301: [PATCH] Fixed some issues with the patches.
Resent-To: guix-patches@gnu.org
Resent-Message-ID: <handler.40301.D40301.158668225931896.done@debbugs.gnu.org>
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
References: <87h7y82cey.fsf@asu.edu> <87o8ryq9h4.fsf@asu.edu>
 <87a73h3ih3.fsf@nicolasgoaziou.fr> <87ftd9r0p0.fsf@asu.edu>
Date: Sun, 12 Apr 2020 11:04:08 +0200
In-Reply-To: <87ftd9r0p0.fsf@asu.edu> (John Soo's message of "Sat, 11 Apr 2020
 17:45:47 -0700")
Message-ID: <87sgh913ef.fsf@nicolasgoaziou.fr>
MIME-Version: 1.0
Content-Type: text/plain
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: John Soo <jsoo1@asu.edu>
Cc: 40301-done@debbugs.gnu.org

Hello,

John Soo <jsoo1@asu.edu> writes:

> Ok I added the revision and the commit and used git-version and
> git-file-name. As an aside, what does the revision mean? Maybe if I
> really understand it I can submit better patches in the future.

If there is no proper versioning for the package (e.g., no releases, or
version strings hidden in a source file), we have to rely on commit
hashes. But commit hashes are not monotonic. So, if you package, e.g.,
"emacs-psc-ide" with commit "bbbb", and later, update it to include
latest commit "aaaa", you have, from Guix's point of view, downgraded
the package, even though "aaaa" is more advanced than "bbbb".

The revision number solves that. Each time you update the commit
message, you increase the revision number, so you releases are
monotonic. E.g., your first package will be "emacs-psc-ide-1-bbbb", and
the other "emacs-psc-ide-2-aaaa".

> Subject: [PATCH] gnu: Add emacs-psc-ide.
>
> * gnu/packages/emacs-xyz.scm (emacs-psc-ide): New variable.

Thank you. Applied as 8a00a2202ef2a0a0173e17479359370f5656ecd0.

Regards,

-- 
Nicolas Goaziou