From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id OHRSBpipxV6yEAAA0tVLHw (envelope-from ) for ; Wed, 20 May 2020 22:05:12 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id ACTuAZipxV4iXwAAbx9fmQ (envelope-from ) for ; Wed, 20 May 2020 22:05:12 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 860EE940415 for ; Wed, 20 May 2020 22:05:11 +0000 (UTC) Received: from localhost ([::1]:40328 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jbWpq-0004Hx-Ez for larch@yhetil.org; Wed, 20 May 2020 18:05:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53552) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jbWok-0001jM-S5 for guix-patches@gnu.org; Wed, 20 May 2020 18:04:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:43052) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jbWok-0006Eh-Ig for guix-patches@gnu.org; Wed, 20 May 2020 18:04:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jbWok-0006Vh-EK for guix-patches@gnu.org; Wed, 20 May 2020 18:04:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#37305] [PATCH v3] Allow booting from a Btrfs subvolume Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 20 May 2020 22:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37305 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxim Cournoyer Cc: Pierre Neidhardt , 37305-done@debbugs.gnu.org Received: via spool by 37305-done@debbugs.gnu.org id=D37305.159001223925014 (code D ref 37305); Wed, 20 May 2020 22:04:02 +0000 Received: (at 37305-done) by debbugs.gnu.org; 20 May 2020 22:03:59 +0000 Received: from localhost ([127.0.0.1]:54598 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jbWoh-0006VO-Ae for submit@debbugs.gnu.org; Wed, 20 May 2020 18:03:59 -0400 Received: from eggs.gnu.org ([209.51.188.92]:46126) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jbWof-0006V9-OF for 37305-done@debbugs.gnu.org; Wed, 20 May 2020 18:03:57 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:59853) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jbWoZ-0006EL-4E; Wed, 20 May 2020 18:03:51 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=56662 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jbWoY-0002hC-7F; Wed, 20 May 2020 18:03:50 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <875zg2xtsb.fsf@gmail.com> <87lfoxbn2e.fsf@gnu.org> <87v9n1pts1.fsf@raisin.i-did-not-set--mail-host-address--so-tickle-me> <87o8qmheqm.fsf@ambrevar.xyz> <874ksebkup.fsf_-_@gmail.com> <87y2pohpqx.fsf@gnu.org> <87v9kqpyhu.fsf@gmail.com> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 3 Prairial an 228 de la =?UTF-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Thu, 21 May 2020 00:03:47 +0200 In-Reply-To: <87v9kqpyhu.fsf@gmail.com> (Maxim Cournoyer's message of "Wed, 20 May 2020 08:44:13 -0400") Message-ID: <87sgfuclh8.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -1.01 X-TUID: Us8WtIeCOdFZ Hi Maxim, Maxim Cournoyer skribis: [...] >>> (define* (grub-configuration-file config entries >>> #:key >>> (system (%current-system)) >>> - (old-entries '())) >>> + (old-entries '()) >>> + btrfs-subvolume-file-name) >> >> I wonder if we should just call it =E2=80=98store-directory-prefix=E2=80= =99 or similar >> since, after all, it=E2=80=99s just about prepending a prefix, which cou= ld >> perhaps be useful for file systems other than Btrfs. >> >> Thoughts? > > Perhaps, but given it's not yet clear whether another file system will > require similar support from GRUB, I'd rather keep things as explicit as > possible for now. To me, another consideration is familiarity with Btrfs for those who=E2=80= =99ll touch the code: to someone not familiar with it, the code may be viewed as =E2=80=9Cread-only=E2=80=9D because it says =E2=80=9Cbtrfs=E2=80=9D. Wh= ereas if it clearly states that it=E2=80=99s just about prepending a directory name or similar, it=E2= =80=99s easy to reason about it. >> Anyway, that=E2=80=99s great work, so I=E2=80=99ll be happy to finally s= ee it committed >> in the coming days! > > Thanks for the great words and for having a last look :-). > > I've added a news entry and pushed to master as: > > 489699c456 allow-booting-from-btrfs-subvolume news: Add entry for Btrfs s= ubvolume boot support. > b460ba7992 bootloader: grub: Allow booting from a Btrfs subvolume. > fa35fb58c8 file-systems: Add helpers for parsing the options string into = an alist. > 281d80d8e5 linux-boot: Refactor boot-system. > > Closing! Thanks to Pierre and Ludovic for testing and reviewing. That=E2=80=99s great news, thanks a lot for your work=E2=80=A6 and for your= patience! Ludo=E2=80=99.